diff options
| author | 2024-01-19 14:12:17 -0800 | |
|---|---|---|
| committer | 2024-01-19 14:15:34 -0800 | |
| commit | 24e25c0499956d78fcbd2b8a9a9b00e773e6949f (patch) | |
| tree | cd98bf43761fc7f8e3bf2a66e2625a6f208fcc74 /java/lint.go | |
| parent | e5d89e4da18eb9bd4e0cb9f5cda51c125a0bdf4e (diff) | |
Re-enable strict updatability linting
Now that all use cases where it would've errored on are removed.
Ignore-AOSP-First: the properties were only removed in internal main to make the LSC smaller
Bug: 320698986
Test: m nothing --no-skip-soong-tests, and also locally edited soong to add a quick build that runs all the strict updatability checks in the tree and ran that
Change-Id: If9e23327a3c0944cc8c6849914fe51dc48bdb626
Diffstat (limited to 'java/lint.go')
| -rw-r--r-- | java/lint.go | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/java/lint.go b/java/lint.go index 91e22a491..bd6c1bae6 100644 --- a/java/lint.go +++ b/java/lint.go @@ -325,14 +325,13 @@ func (l *linter) writeLintProjectXML(ctx android.ModuleContext, rule *android.Ru cmd.FlagForEachArg("--error_check ", l.properties.Lint.Error_checks) cmd.FlagForEachArg("--fatal_check ", l.properties.Lint.Fatal_checks) - // TODO(b/193460475): Re-enable strict updatability linting - //if l.GetStrictUpdatabilityLinting() { - // // Verify the module does not baseline issues that endanger safe updatability. - // if baselinePath := l.getBaselineFilepath(ctx); baselinePath.Valid() { - // cmd.FlagWithInput("--baseline ", baselinePath.Path()) - // cmd.FlagForEachArg("--disallowed_issues ", updatabilityChecks) - // } - //} + if l.GetStrictUpdatabilityLinting() { + // Verify the module does not baseline issues that endanger safe updatability. + if l.properties.Lint.Baseline_filename != nil { + cmd.FlagWithInput("--baseline ", android.PathForModuleSrc(ctx, *l.properties.Lint.Baseline_filename)) + cmd.FlagForEachArg("--disallowed_issues ", updatabilityChecks) + } + } return lintPaths{ projectXML: projectXMLPath, |