diff options
| author | 2020-07-09 21:58:57 +0000 | |
|---|---|---|
| committer | 2020-07-09 21:58:57 +0000 | |
| commit | d295daa19a90862d5bac5044b356a9c43074bb4a (patch) | |
| tree | 743ef882f7d8316958ad14987bc380857d55821b /java/java_test.go | |
| parent | 0f472e62f9d679bd4553c06bce2a99bb4d122db9 (diff) | |
| parent | e371a18acc20ca53b55bf9784c28608d7ea8bdac (diff) | |
Ensure that sdk/module_exports depends on source members am: cee7e66b07 am: e371a18acc
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1359444
Change-Id: If241aea3d4997adfa1edea5e17c35b02f6bc0eb6
Diffstat (limited to 'java/java_test.go')
| -rw-r--r-- | java/java_test.go | 27 |
1 files changed, 6 insertions, 21 deletions
diff --git a/java/java_test.go b/java/java_test.go index 59a2ce7aa..fb003619f 100644 --- a/java/java_test.go +++ b/java/java_test.go @@ -25,7 +25,6 @@ import ( "strings" "testing" - "github.com/google/blueprint" "github.com/google/blueprint/proptools" "android/soong/android" @@ -173,20 +172,6 @@ func moduleToPath(name string) string { } } -func checkModuleDependencies(t *testing.T, ctx *android.TestContext, name, variant string, expected []string) { - t.Helper() - module := ctx.ModuleForTests(name, variant).Module() - deps := []string{} - ctx.VisitDirectDeps(module, func(m blueprint.Module) { - deps = append(deps, m.Name()) - }) - sort.Strings(deps) - - if actual := deps; !reflect.DeepEqual(expected, actual) { - t.Errorf("expected %#q, found %#q", expected, actual) - } -} - func TestJavaLinkType(t *testing.T) { testJava(t, ` java_library { @@ -647,7 +632,7 @@ func TestJavaSdkLibraryImport(t *testing.T) { } } - checkModuleDependencies(t, ctx, "sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ `prebuilt_sdklib.stubs`, `prebuilt_sdklib.stubs.source.test`, `prebuilt_sdklib.stubs.system`, @@ -675,7 +660,7 @@ func TestJavaSdkLibraryImport_WithSource(t *testing.T) { } `) - checkModuleDependencies(t, ctx, "sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ `dex2oatd`, `prebuilt_sdklib`, `sdklib.impl`, @@ -684,7 +669,7 @@ func TestJavaSdkLibraryImport_WithSource(t *testing.T) { `sdklib.xml`, }) - checkModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ `prebuilt_sdklib.stubs`, `sdklib.impl`, // This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the @@ -715,7 +700,7 @@ func TestJavaSdkLibraryImport_Preferred(t *testing.T) { } `) - checkModuleDependencies(t, ctx, "sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ `dex2oatd`, `prebuilt_sdklib`, `sdklib.impl`, @@ -724,7 +709,7 @@ func TestJavaSdkLibraryImport_Preferred(t *testing.T) { `sdklib.xml`, }) - checkModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "prebuilt_sdklib", "android_common", []string{ `prebuilt_sdklib.stubs`, `sdklib.impl`, `sdklib.xml`, @@ -1491,7 +1476,7 @@ func TestJavaSdkLibrary_Deps(t *testing.T) { } `) - checkModuleDependencies(t, ctx, "sdklib", "android_common", []string{ + CheckModuleDependencies(t, ctx, "sdklib", "android_common", []string{ `dex2oatd`, `sdklib.impl`, `sdklib.stubs`, |