diff options
author | 2023-12-07 13:10:56 -0800 | |
---|---|---|
committer | 2023-12-08 13:51:05 -0800 | |
commit | 8ff105860d20f2ccbb8d8044bf562f94100b7f6a (patch) | |
tree | b01575cd628eb36807b7ca274de28fd6a1971e17 /java/java_test.go | |
parent | e51c6e4109e8063e54cf7d8ced1b7da7f9359c34 (diff) |
Remove ConvertWithBp2build implementations
Remove the ConvertWithBp2build implementations from all the module
types, along with the related code.
Bug: 315353489
Test: m blueprint_tests
Change-Id: I212672286686a318893bc7348ddd5a5ec51e77a7
Diffstat (limited to 'java/java_test.go')
-rw-r--r-- | java/java_test.go | 118 |
1 files changed, 1 insertions, 117 deletions
diff --git a/java/java_test.go b/java/java_test.go index d4b056bc9..8e83fc412 100644 --- a/java/java_test.go +++ b/java/java_test.go @@ -1205,7 +1205,7 @@ func TestPatchModule(t *testing.T) { expected := "java.base=.:out/soong" checkPatchModuleFlag(t, ctx, "bar", expected) expected = "java.base=" + strings.Join([]string{ - ".", "out/soong", "dir", "dir2", "nested", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":") + ".", "out/soong", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":") checkPatchModuleFlag(t, ctx, "baz", expected) }) } @@ -1290,43 +1290,6 @@ func TestAidlExportIncludeDirsFromImports(t *testing.T) { } } -func TestAidlIncludeDirFromConvertedFileGroupWithPathPropInMixedBuilds(t *testing.T) { - // TODO(b/247782695), TODO(b/242847534) Fix mixed builds for filegroups - t.Skip("Re-enable once filegroups are corrected for mixed builds") - bp := ` - filegroup { - name: "foo_aidl", - srcs: ["aidl/foo/IFoo.aidl"], - path: "aidl/foo", - bazel_module: { label: "//:foo_aidl" }, - } - java_library { - name: "foo", - srcs: [":foo_aidl"], - } -` - - outBaseDir := "out/bazel/output" - result := android.GroupFixturePreparers( - prepareForJavaTest, - android.PrepareForTestWithFilegroup, - android.FixtureModifyConfig(func(config android.Config) { - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: outBaseDir, - LabelToOutputFiles: map[string][]string{ - "//:foo_aidl": []string{"aidl/foo/IFoo.aidl"}, - }, - } - }), - ).RunTestWithBp(t, bp) - - aidlCommand := result.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command - expectedAidlFlag := "-I" + outBaseDir + "/execroot/__main__/aidl/foo" - if !strings.Contains(aidlCommand, expectedAidlFlag) { - t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag) - } -} - func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) { ctx, _ := testJava(t, ` java_library { @@ -1743,85 +1706,6 @@ func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) { } } -func TestImportMixedBuild(t *testing.T) { - bp := ` - java_import { - name: "baz", - jars: [ - "test1.jar", - "test2.jar", - ], - bazel_module: { label: "//foo/bar:baz" }, - } - ` - - ctx := android.GroupFixturePreparers( - prepareForJavaTest, - android.FixtureModifyConfig(func(config android.Config) { - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: "outputbase", - LabelToOutputFiles: map[string][]string{ - "//foo/bar:baz": []string{"test1.jar", "test2.jar"}, - }, - } - }), - ).RunTestWithBp(t, bp) - - bazMod := ctx.ModuleForTests("baz", "android_common").Module() - producer := bazMod.(android.OutputFileProducer) - expectedOutputFiles := []string{".intermediates/baz/android_common/bazelCombined/baz.jar"} - - outputFiles, err := producer.OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting java_import outputfiles %s", err) - } - actualOutputFiles := android.NormalizePathsForTesting(outputFiles) - android.AssertDeepEquals(t, "Output files are produced", expectedOutputFiles, actualOutputFiles) - - javaInfoProvider := ctx.ModuleProvider(bazMod, JavaInfoProvider) - javaInfo, ok := javaInfoProvider.(JavaInfo) - if !ok { - t.Error("could not get JavaInfo from java_import module") - } - android.AssertDeepEquals(t, "Header JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.HeaderJars)) - android.AssertDeepEquals(t, "Implementation/Resources JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationAndResourcesJars)) - android.AssertDeepEquals(t, "Implementation JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationJars)) -} - -func TestGenAidlIncludeFlagsForMixedBuilds(t *testing.T) { - bazelOutputBaseDir := filepath.Join("out", "bazel") - result := android.GroupFixturePreparers( - PrepareForIntegrationTestWithJava, - android.FixtureModifyConfig(func(config android.Config) { - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: bazelOutputBaseDir, - } - }), - ).RunTest(t) - - ctx := &android.TestPathContext{TestResult: result} - - srcDirectory := filepath.Join("frameworks", "base") - srcDirectoryAlreadyIncluded := filepath.Join("frameworks", "base", "core", "java") - bazelSrcDirectory := android.PathForBazelOut(ctx, srcDirectory) - bazelSrcDirectoryAlreadyIncluded := android.PathForBazelOut(ctx, srcDirectoryAlreadyIncluded) - srcs := android.Paths{ - android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl.aidl"), - android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl2.aidl"), - android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidlExclude.aidl"), - android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidl2Exclude.aidl"), - } - dirsAlreadyIncluded := android.Paths{ - android.PathForTesting(srcDirectoryAlreadyIncluded), - } - - expectedFlags := " -Iout/bazel/execroot/__main__/frameworks/base" - flags := genAidlIncludeFlags(ctx, srcs, dirsAlreadyIncluded) - if flags != expectedFlags { - t.Errorf("expected flags to be %q; was %q", expectedFlags, flags) - } -} - func TestDeviceBinaryWrapperGeneration(t *testing.T) { // Scenario 1: java_binary has main_class property in its bp ctx, _ := testJava(t, ` |