diff options
author | 2023-10-18 20:38:37 +0000 | |
---|---|---|
committer | 2023-10-18 20:38:37 +0000 | |
commit | e11182283f088d1b10a8f03b45339607f6da6fa7 (patch) | |
tree | 9d7fcba4e321794cfd21c2950d9dccee3957679e /java/java.go | |
parent | 05f487a4cda0fff607ee2f00509647d94cb1400d (diff) |
Revert "Don't use java_library for java_import neverlink"
Revert submission 2786699-import-sdk-version-none
Reason for revert: b/306220520
Reverted changes: /q/submissionid:2786699-import-sdk-version-none
Change-Id: I4fbe5fa54dc11fac898a7f15704833f01b9fa269
Diffstat (limited to 'java/java.go')
-rw-r--r-- | java/java.go | 43 |
1 files changed, 15 insertions, 28 deletions
diff --git a/java/java.go b/java/java.go index 0594a8b93..990a084f7 100644 --- a/java/java.go +++ b/java/java.go @@ -3403,14 +3403,9 @@ func createLibraryTarget(ctx android.Bp2buildMutatorContext, libInfo libraryCrea return libName } -type importAttributes struct { - Jars bazel.LabelListAttribute - Exports bazel.LabelListAttribute - Neverlink *bool -} - -type filegroupAttrs struct { - Srcs bazel.LabelListAttribute +type bazelJavaImportAttributes struct { + Jars bazel.LabelListAttribute + Exports bazel.LabelListAttribute } // java_import bp2Build converter. @@ -3426,36 +3421,28 @@ func (i *Import) ConvertWithBp2build(ctx android.Bp2buildMutatorContext) { } } - name := android.RemoveOptionalPrebuiltPrefix(i.Name()) - filegroupTargetName := name + "-jars" - - ctx.CreateBazelTargetModule( - bazel.BazelTargetModuleProperties{ - Rule_class: "filegroup", - Bzl_load_location: "//build/bazel/rules:filegroup.bzl", - }, - android.CommonAttributes{Name: filegroupTargetName}, - &filegroupAttrs{ - Srcs: jars, - }, - ) - - attrs := &importAttributes{ - Jars: bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + filegroupTargetName}), + attrs := &bazelJavaImportAttributes{ + Jars: jars, } props := bazel.BazelTargetModuleProperties{ Rule_class: "java_import", Bzl_load_location: "//build/bazel/rules/java:import.bzl", } + name := android.RemoveOptionalPrebuiltPrefix(i.Name()) + ctx.CreateBazelTargetModule(props, android.CommonAttributes{Name: name}, attrs) - neverlinkAttrs := &importAttributes{ - Jars: attrs.Jars, - Neverlink: proptools.BoolPtr(true), + neverlink := true + neverlinkAttrs := &javaLibraryAttributes{ + Neverlink: bazel.BoolAttribute{Value: &neverlink}, + Exports: bazel.MakeSingleLabelListAttribute(bazel.Label{Label: ":" + name}), + javaCommonAttributes: &javaCommonAttributes{ + Sdk_version: bazel.StringAttribute{Value: proptools.StringPtr("none")}, + }, } ctx.CreateBazelTargetModule( - props, + javaLibraryBazelTargetModuleProperties(), android.CommonAttributes{Name: name + "-neverlink"}, neverlinkAttrs) } |