summaryrefslogtreecommitdiff
path: root/java/java.go
diff options
context:
space:
mode:
author Spandan Das <spandandas@google.com> 2023-02-28 16:44:53 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2023-02-28 16:44:53 +0000
commitc8054ec6ac5ca37c24cd7bc8e917dad062042935 (patch)
tree184361d4b7da576658e80569fa0a6d9b1d7dd908 /java/java.go
parente1271f8c2d8b3fd3cbfa6f2cb7ef9479bf4d4117 (diff)
parent7fa982c0ecd1af67b1d83e8bc932e398efc22d21 (diff)
Merge "Update usages of min_sdk_version that relies on (kind+level)"
Diffstat (limited to 'java/java.go')
-rw-r--r--java/java.go13
1 files changed, 8 insertions, 5 deletions
diff --git a/java/java.go b/java/java.go
index 27b2a6ec6..1df45b804 100644
--- a/java/java.go
+++ b/java/java.go
@@ -2166,15 +2166,18 @@ func (j *Import) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Modu
// Implements android.ApexModule
func (j *Import) ShouldSupportSdkVersion(ctx android.BaseModuleContext,
sdkVersion android.ApiLevel) error {
- sdkSpec := j.MinSdkVersion(ctx)
- if !sdkSpec.Specified() {
+ sdkVersionSpec := j.SdkVersion(ctx)
+ minSdkVersionSpec := j.MinSdkVersion(ctx)
+ if !minSdkVersionSpec.Specified() {
return fmt.Errorf("min_sdk_version is not specified")
}
- if sdkSpec.Kind == android.SdkCore {
+ // If the module is compiling against core (via sdk_version), skip comparison check.
+ if sdkVersionSpec.Kind == android.SdkCore {
return nil
}
- if sdkSpec.ApiLevel.GreaterThan(sdkVersion) {
- return fmt.Errorf("newer SDK(%v)", sdkSpec.ApiLevel)
+ minSdkVersion := minSdkVersionSpec.ApiLevel
+ if minSdkVersion.GreaterThan(sdkVersion) {
+ return fmt.Errorf("newer SDK(%v)", minSdkVersion)
}
return nil
}