diff options
author | 2019-07-30 17:55:33 +0900 | |
---|---|---|
committer | 2019-08-08 08:09:01 +0900 | |
commit | 093f0eb1331dffaab23e9252d2a4dbc6a27156f0 (patch) | |
tree | 553e58232b36b5c20ebca2877cb68b7b015f0a2e /java/gen.go | |
parent | 0c31c688dc08acf4a4d070fbce167982c1ac6589 (diff) |
Implement sysprop_library API stability check
sysprop_library now checks the API stability itself, cutting dependency
on java_sdk_library. Under the directory {module_dir}/api,
{module_name}-current.txt and {module_name}-latest.txt hold API
signatures.
When sysprop_library is built, or a user run "m {module_name}-check-api"
command, API check is performed. First, current.txt must have exactly
same signature with built sysprop_library module. Second, current.txt
must be compatible with latest.txt.
Build system emits a handy error message to generate/update those API
files, in case of missing or mismatching. Also, a script file for
freezing API files is introduced.
Bug: 131637873
Test: 1) m && boot blueline
Test: 2) m {sysprop_library} performs API check
Test: 3) manual test for check-api, freezing api
Change-Id: I9d25f5dc64299e666527ca8e23d7233966901c4e
Diffstat (limited to 'java/gen.go')
-rw-r--r-- | java/gen.go | 31 |
1 files changed, 27 insertions, 4 deletions
diff --git a/java/gen.go b/java/gen.go index 69965ecec..81fc3417f 100644 --- a/java/gen.go +++ b/java/gen.go @@ -53,13 +53,13 @@ var ( sysprop = pctx.AndroidStaticRule("sysprop", blueprint.RuleParams{ Command: `rm -rf $out.tmp && mkdir -p $out.tmp && ` + - `$syspropCmd --java-output-dir $out.tmp $in && ` + + `$syspropCmd --scope $scope --java-output-dir $out.tmp $in && ` + `${config.SoongZipCmd} -jar -o $out -C $out.tmp -D $out.tmp && rm -rf $out.tmp`, CommandDeps: []string{ "$syspropCmd", "${config.SoongZipCmd}", }, - }) + }, "scope") ) func genAidl(ctx android.ModuleContext, aidlFile android.Path, aidlFlags string, deps android.Paths) android.Path { @@ -98,7 +98,7 @@ func genLogtags(ctx android.ModuleContext, logtagsFile android.Path) android.Pat return javaFile } -func genSysprop(ctx android.ModuleContext, syspropFile android.Path) android.Path { +func genSysprop(ctx android.ModuleContext, syspropFile android.Path, scope string) android.Path { srcJarFile := android.GenPathWithExt(ctx, "sysprop", syspropFile, "srcjar") ctx.Build(pctx, android.BuildParams{ @@ -106,6 +106,9 @@ func genSysprop(ctx android.ModuleContext, syspropFile android.Path) android.Pat Description: "sysprop_java " + syspropFile.Rel(), Output: srcJarFile, Input: syspropFile, + Args: map[string]string{ + "scope": scope, + }, }) return srcJarFile @@ -129,7 +132,27 @@ func (j *Module) genSources(ctx android.ModuleContext, srcFiles android.Paths, srcJarFile := genProto(ctx, srcFile, flags.proto) outSrcFiles = append(outSrcFiles, srcJarFile) case ".sysprop": - srcJarFile := genSysprop(ctx, srcFile) + // internal scope contains all properties + // public scope only contains public properties + // use public if the owner is different from client + scope := "internal" + if j.properties.Sysprop.Platform != nil { + isProduct := ctx.ProductSpecific() + isVendor := ctx.SocSpecific() + isOwnerPlatform := Bool(j.properties.Sysprop.Platform) + + if isProduct { + // product can't own any sysprop_library now, so product must use public scope + scope = "public" + } else if isVendor && !isOwnerPlatform { + // vendor and odm can't use system's internal property. + scope = "public" + } + + // We don't care about clients under system. + // They can't use sysprop_library owned by other partitions. + } + srcJarFile := genSysprop(ctx, srcFile, scope) outSrcFiles = append(outSrcFiles, srcJarFile) default: outSrcFiles = append(outSrcFiles, srcFile) |