diff options
| author | 2021-06-17 13:33:09 +0100 | |
|---|---|---|
| committer | 2021-06-18 07:43:32 +0100 | |
| commit | 155c17779c5e5937fa987b81df6697fc3c23607e (patch) | |
| tree | 6a48e52981d206aebada7ce0e7f9727004fe49eb /java/classpath_fragment.go | |
| parent | 5466a3699c550d1fa67066db48951b765156be4f (diff) | |
Extract createEntriesForApexFile
While this seems like a simple refactoring it does actually fix an
issue. Previously, when the ExtraEntries func was being defined inline
within the for ... loop it used the loop variable "fi". Unfortunately,
that meant that the func created on each iteration ended up using the
value for "fi" that was set on the last iteration.
Extracting the creation of the entry into a separate method means that
each func created gets its own "fi" variable with the correct values.
Bug: 177892522
Test: m SOONG_CONFIG_art_module_source_build=false nothing
- without this change it reported duplicate rules for apache-xml.jar
which is the last entry in the art-bootclasspath-fragment. With
this change it works fine.
Change-Id: Ia063b513f758e1bbe73407c0441b72453f412acf
Diffstat (limited to 'java/classpath_fragment.go')
0 files changed, 0 insertions, 0 deletions