summaryrefslogtreecommitdiff
path: root/java/app.go
diff options
context:
space:
mode:
author Treehugger Robot <treehugger-gerrit@google.com> 2020-06-08 07:27:26 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2020-06-08 07:27:26 +0000
commit8a624337b308f70151a9f50f8ef29fd636f7e98c (patch)
tree11aa948441f667c75b5b3c6d022a4cc5ad674618 /java/app.go
parent37ed5063e2439542b5ab5199bbe28a452d833bf9 (diff)
parent652d5b31ef7822b2fe9ba59638011864718eb568 (diff)
Merge "Use sdkSpec to compare sdk_versions of APK/JNI"
Diffstat (limited to 'java/app.go')
-rwxr-xr-xjava/app.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/java/app.go b/java/app.go
index 5f36e85f1..24dde79f4 100755
--- a/java/app.go
+++ b/java/app.go
@@ -445,8 +445,11 @@ func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVer
return
}
dep, _ := m.(*cc.Module)
- jniSdkVersion, err := android.ApiStrToNum(ctx, dep.SdkVersion())
- if err != nil || int(minSdkVersion) < jniSdkVersion {
+ // The domain of cc.sdk_version is "current" and <number>
+ // We can rely on sdkSpec to convert it to <number> so that "current" is handled
+ // properly regardless of sdk finalization.
+ jniSdkVersion, err := sdkSpecFrom(dep.SdkVersion()).effectiveVersion(ctx)
+ if err != nil || minSdkVersion < jniSdkVersion {
ctx.OtherModuleErrorf(dep, "sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
dep.SdkVersion(), minSdkVersion, ctx.ModuleName())
return