summaryrefslogtreecommitdiff
path: root/java/app.go
diff options
context:
space:
mode:
author Spandan Das <spandandas@google.com> 2024-12-03 00:00:41 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> 2024-12-03 00:00:41 +0000
commit5845e63457cba07fd654a48e243d660827eb4f09 (patch)
treeffc5cc042919514cdcd10dfafb4ccffb3dcdbdbc /java/app.go
parent22dd3c90db0ff8f45bd0ca12a599101746ee22f0 (diff)
parent5c7d97924127d192fa6bf3e094da687909d14d6f (diff)
Merge "Revert "Skip packaging cross container cc deps of apk-in-apex"" into main am: 5c7d979241
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/3387669 Change-Id: Ie5cefc8925a256932b45045283148d0eab042e10 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
Diffstat (limited to 'java/app.go')
-rw-r--r--java/app.go16
1 files changed, 3 insertions, 13 deletions
diff --git a/java/app.go b/java/app.go
index 832a0831f..7f80160a3 100644
--- a/java/app.go
+++ b/java/app.go
@@ -1082,17 +1082,7 @@ func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
}
jniLib, prebuiltJniPackages := collectJniDeps(ctx, shouldCollectRecursiveNativeDeps,
- checkNativeSdkVersion, func(parent, child android.Module) bool {
- childLinkable, _ := child.(cc.LinkableInterface)
- parentLinkable, _ := parent.(cc.LinkableInterface)
- useStubsOfDep := childLinkable.IsStubs()
- if parent.(android.ApexModule).NotInPlatform() && parentLinkable != nil {
- // APK-in-APEX
- // If the parent is a linkable interface, use stubs if the dependency edge crosses an apex boundary.
- useStubsOfDep = useStubsOfDep || (childLinkable.HasStubsVariants() && cc.ShouldUseStubForApex(ctx, parent, child))
- }
- return !childLinkable.IsNdk(ctx.Config()) && !useStubsOfDep
- })
+ checkNativeSdkVersion, func(dep cc.LinkableInterface) bool { return !dep.IsNdk(ctx.Config()) && !dep.IsStubs() })
var certificates []Certificate
@@ -1127,7 +1117,7 @@ func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
func collectJniDeps(ctx android.ModuleContext,
shouldCollectRecursiveNativeDeps bool,
checkNativeSdkVersion bool,
- filter func(parent, child android.Module) bool) ([]jniLib, android.Paths) {
+ filter func(cc.LinkableInterface) bool) ([]jniLib, android.Paths) {
var jniLibs []jniLib
var prebuiltJniPackages android.Paths
seenModulePaths := make(map[string]bool)
@@ -1138,7 +1128,7 @@ func collectJniDeps(ctx android.ModuleContext,
if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
if dep, ok := module.(cc.LinkableInterface); ok {
- if filter != nil && !filter(parent, module) {
+ if filter != nil && !filter(dep) {
return false
}