diff options
author | 2024-10-11 09:49:48 -0700 | |
---|---|---|
committer | 2024-10-11 10:08:01 -0700 | |
commit | c7e58c90be57a9b48a4ecd1eff1fde66df4c72b0 (patch) | |
tree | 0e300fd196e926948e4c5064297f620e3cea4249 /fsgen/filesystem_creator.go | |
parent | c307d014ff6d3c0788b808d3e4bdcabd69aa22ab (diff) |
Use global mutex for fsDeps update
Test: m, test race in test execution locally, CI
Change-Id: Ia0ff5b37f5bc6e53d70e6c987058feb148130134
Diffstat (limited to 'fsgen/filesystem_creator.go')
-rw-r--r-- | fsgen/filesystem_creator.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fsgen/filesystem_creator.go b/fsgen/filesystem_creator.go index e97fce6b5..f10b2ba11 100644 --- a/fsgen/filesystem_creator.go +++ b/fsgen/filesystem_creator.go @@ -45,6 +45,7 @@ func RegisterCollectFileSystemDepsMutators(ctx android.RegisterMutatorsContext) ctx.BottomUp("fs_collect_deps", collectDepsMutator).MutatesGlobalState() } +var fsDepsMutex = sync.Mutex{} var collectFsDepsOnceKey = android.NewOnceKey("CollectFsDeps") var depCandidatesOnceKey = android.NewOnceKey("DepCandidates") @@ -80,12 +81,11 @@ func collectDepsMutator(mctx android.BottomUpMutatorContext) { }).(*[]string) m := mctx.Module() - mutex := &sync.Mutex{} if slices.Contains(*depCandidates, m.Name()) { if installInSystem(mctx, m) { - mutex.Lock() + fsDepsMutex.Lock() *fsDeps = append(*fsDeps, m.Name()) - mutex.Unlock() + fsDepsMutex.Unlock() } } } |