diff options
author | 2023-12-07 13:10:56 -0800 | |
---|---|---|
committer | 2023-12-08 13:51:05 -0800 | |
commit | 8ff105860d20f2ccbb8d8044bf562f94100b7f6a (patch) | |
tree | b01575cd628eb36807b7ca274de28fd6a1971e17 /cc/library_test.go | |
parent | e51c6e4109e8063e54cf7d8ced1b7da7f9359c34 (diff) |
Remove ConvertWithBp2build implementations
Remove the ConvertWithBp2build implementations from all the module
types, along with the related code.
Bug: 315353489
Test: m blueprint_tests
Change-Id: I212672286686a318893bc7348ddd5a5ec51e77a7
Diffstat (limited to 'cc/library_test.go')
-rw-r--r-- | cc/library_test.go | 233 |
1 files changed, 0 insertions, 233 deletions
diff --git a/cc/library_test.go b/cc/library_test.go index dbe2be899..2ed2d761c 100644 --- a/cc/library_test.go +++ b/cc/library_test.go @@ -19,7 +19,6 @@ import ( "testing" "android/soong/android" - "android/soong/bazel/cquery" ) func TestLibraryReuse(t *testing.T) { @@ -246,137 +245,6 @@ func TestStubsVersions_ParseError(t *testing.T) { testCcError(t, `"libfoo" .*: versions: "X" could not be parsed as an integer and is not a recognized codename`, bp) } -func TestCcLibraryWithBazel(t *testing.T) { - t.Parallel() - bp := ` -cc_library { - name: "foo", - srcs: ["foo.cc"], - bazel_module: { label: "//foo/bar:bar" }, -}` - config := TestConfig(t.TempDir(), android.Android, nil, bp, nil) - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: "outputbase", - LabelToCcInfo: map[string]cquery.CcInfo{ - "//foo/bar:bar": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - Headers: []string{"foo.h"}, - RootDynamicLibraries: []string{"foo.so"}, - UnstrippedOutput: "foo_unstripped.so", - }, - "//foo/bar:bar_bp2build_cc_library_static": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - Headers: []string{"foo.h"}, - RootStaticArchives: []string{"foo.a"}, - }, - }, - } - ctx := testCcWithConfig(t, config) - - staticFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_static").Module() - outputFiles, err := staticFoo.(android.OutputFileProducer).OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_object outputfiles %s", err) - } - - expectedOutputFiles := []string{"outputbase/execroot/__main__/foo.a"} - android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings()) - - flagExporter := ctx.ModuleProvider(staticFoo, FlagExporterInfoProvider).(FlagExporterInfo) - android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders) - android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps) - - sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module() - outputFiles, err = sharedFoo.(android.OutputFileProducer).OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_library outputfiles %s", err) - } - expectedOutputFiles = []string{"outputbase/execroot/__main__/foo.so"} - android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings()) - - android.AssertStringEquals(t, "unstripped shared library", "outputbase/execroot/__main__/foo_unstripped.so", sharedFoo.(*Module).linker.unstrippedOutputFilePath().String()) - flagExporter = ctx.ModuleProvider(sharedFoo, FlagExporterInfoProvider).(FlagExporterInfo) - android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders) - android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps) -} - -func TestCcLibraryWithBazelValidations(t *testing.T) { - t.Parallel() - bp := ` -cc_library { - name: "foo", - srcs: ["foo.cc"], - bazel_module: { label: "//foo/bar:bar" }, - tidy: true, -}` - config := TestConfig(t.TempDir(), android.Android, nil, bp, nil) - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: "outputbase", - LabelToCcInfo: map[string]cquery.CcInfo{ - "//foo/bar:bar": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - Headers: []string{"foo.h"}, - RootDynamicLibraries: []string{"foo.so"}, - UnstrippedOutput: "foo_unstripped.so", - }, - "//foo/bar:bar_bp2build_cc_library_static": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - Headers: []string{"foo.h"}, - RootStaticArchives: []string{"foo.a"}, - TidyFiles: []string{"foo.c.tidy"}, - }, - }, - } - ctx := android.GroupFixturePreparers( - prepareForCcTest, - android.FixtureMergeEnv(map[string]string{ - "ALLOW_LOCAL_TIDY_TRUE": "1", - }), - ).RunTestWithConfig(t, config).TestContext - - staticFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_static").Module() - outputFiles, err := staticFoo.(android.OutputFileProducer).OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_object outputfiles %s", err) - } - - expectedOutputFiles := []string{"out/soong/.intermediates/foo/android_arm_armv7-a-neon_static/validated/foo.a"} - android.AssertPathsRelativeToTopEquals(t, "output files", expectedOutputFiles, outputFiles) - - flagExporter := ctx.ModuleProvider(staticFoo, FlagExporterInfoProvider).(FlagExporterInfo) - android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders) - android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps) - - sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module() - outputFiles, err = sharedFoo.(android.OutputFileProducer).OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_library outputfiles %s", err) - } - expectedOutputFiles = []string{"outputbase/execroot/__main__/foo.so"} - android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings()) - - android.AssertStringEquals(t, "unstripped shared library", "outputbase/execroot/__main__/foo_unstripped.so", sharedFoo.(*Module).linker.unstrippedOutputFilePath().String()) - flagExporter = ctx.ModuleProvider(sharedFoo, FlagExporterInfoProvider).(FlagExporterInfo) - android.AssertPathsRelativeToTopEquals(t, "exported include dirs", []string{"outputbase/execroot/__main__/include"}, flagExporter.IncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported system include dirs", []string{"outputbase/execroot/__main__/system_include"}, flagExporter.SystemIncludeDirs) - android.AssertPathsRelativeToTopEquals(t, "exported headers", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.GeneratedHeaders) - android.AssertPathsRelativeToTopEquals(t, "deps", []string{"outputbase/execroot/__main__/foo.h"}, flagExporter.Deps) -} - func TestLibraryVersionScript(t *testing.T) { t.Parallel() result := PrepareForIntegrationTestWithCc.RunTestWithBp(t, ` @@ -413,107 +281,6 @@ func TestLibraryDynamicList(t *testing.T) { } -func TestCcLibrarySharedWithBazelValidations(t *testing.T) { - t.Parallel() - bp := ` -cc_library_shared { - name: "foo", - srcs: ["foo.cc"], - bazel_module: { label: "//foo/bar:bar" }, - tidy: true, -}` - config := TestConfig(t.TempDir(), android.Android, nil, bp, nil) - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: "outputbase", - LabelToCcInfo: map[string]cquery.CcInfo{ - "//foo/bar:bar": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - RootDynamicLibraries: []string{"foo.so"}, - TocFile: "foo.so.toc", - TidyFiles: []string{"foo.c.tidy"}, - }, - }, - } - ctx := android.GroupFixturePreparers( - prepareForCcTest, - android.FixtureMergeEnv(map[string]string{ - "ALLOW_LOCAL_TIDY_TRUE": "1", - }), - ).RunTestWithConfig(t, config).TestContext - - sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module() - producer := sharedFoo.(android.OutputFileProducer) - outputFiles, err := producer.OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_object outputfiles %s", err) - } - expectedOutputFiles := []string{"out/soong/.intermediates/foo/android_arm_armv7-a-neon_shared/validated/foo.so"} - android.AssertPathsRelativeToTopEquals(t, "output files", expectedOutputFiles, outputFiles) - - tocFilePath := sharedFoo.(*Module).Toc() - if !tocFilePath.Valid() { - t.Errorf("Invalid tocFilePath: %s", tocFilePath) - } - tocFile := tocFilePath.Path() - expectedToc := "outputbase/execroot/__main__/foo.so.toc" - android.AssertStringEquals(t, "toc file", expectedToc, tocFile.String()) - - entries := android.AndroidMkEntriesForTest(t, ctx, sharedFoo)[0] - expectedFlags := []string{"-Ioutputbase/execroot/__main__/include", "-isystem outputbase/execroot/__main__/system_include"} - gotFlags := entries.EntryMap["LOCAL_EXPORT_CFLAGS"] - android.AssertDeepEquals(t, "androidmk exported cflags", expectedFlags, gotFlags) - android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "cc_library_shared", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) -} - -func TestCcLibrarySharedWithBazel(t *testing.T) { - t.Parallel() - bp := ` -cc_library_shared { - name: "foo", - srcs: ["foo.cc"], - bazel_module: { label: "//foo/bar:bar" }, -}` - config := TestConfig(t.TempDir(), android.Android, nil, bp, nil) - config.BazelContext = android.MockBazelContext{ - OutputBaseDir: "outputbase", - LabelToCcInfo: map[string]cquery.CcInfo{ - "//foo/bar:bar": cquery.CcInfo{ - CcObjectFiles: []string{"foo.o"}, - Includes: []string{"include"}, - SystemIncludes: []string{"system_include"}, - RootDynamicLibraries: []string{"foo.so"}, - TocFile: "foo.so.toc", - }, - }, - } - ctx := testCcWithConfig(t, config) - - sharedFoo := ctx.ModuleForTests("foo", "android_arm_armv7-a-neon_shared").Module() - producer := sharedFoo.(android.OutputFileProducer) - outputFiles, err := producer.OutputFiles("") - if err != nil { - t.Errorf("Unexpected error getting cc_object outputfiles %s", err) - } - expectedOutputFiles := []string{"outputbase/execroot/__main__/foo.so"} - android.AssertDeepEquals(t, "output files", expectedOutputFiles, outputFiles.Strings()) - - tocFilePath := sharedFoo.(*Module).Toc() - if !tocFilePath.Valid() { - t.Errorf("Invalid tocFilePath: %s", tocFilePath) - } - tocFile := tocFilePath.Path() - expectedToc := "outputbase/execroot/__main__/foo.so.toc" - android.AssertStringEquals(t, "toc file", expectedToc, tocFile.String()) - - entries := android.AndroidMkEntriesForTest(t, ctx, sharedFoo)[0] - expectedFlags := []string{"-Ioutputbase/execroot/__main__/include", "-isystem outputbase/execroot/__main__/system_include"} - gotFlags := entries.EntryMap["LOCAL_EXPORT_CFLAGS"] - android.AssertDeepEquals(t, "androidmk exported cflags", expectedFlags, gotFlags) - android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "cc_library_shared", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0]) -} - func TestWholeStaticLibPrebuilts(t *testing.T) { t.Parallel() result := PrepareForIntegrationTestWithCc.RunTestWithBp(t, ` |