summaryrefslogtreecommitdiff
path: root/apex/apex.go
diff options
context:
space:
mode:
author Colin Cross <ccross@android.com> 2024-09-26 18:38:11 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2024-09-26 18:38:11 +0000
commit26a7d34e6d17b99bc9e66d32c2199123a7dd0f99 (patch)
tree9a69a8d0d5bf2b44fd931e1cbf9227c0aae9b16c /apex/apex.go
parent4649b1fb6542ffb51c10c5f4ba2534d19a67253a (diff)
parent18cb570c4c7676fc47fca26bc1e4c494da29c8bf (diff)
Merge "Only propgate strict updatability linting to modules that are in the apex" into main
Diffstat (limited to 'apex/apex.go')
-rw-r--r--apex/apex.go25
1 files changed, 3 insertions, 22 deletions
diff --git a/apex/apex.go b/apex/apex.go
index ded21753c..aff69c12f 100644
--- a/apex/apex.go
+++ b/apex/apex.go
@@ -1122,19 +1122,11 @@ func apexStrictUpdatibilityLintMutator(mctx android.TopDownMutatorContext) {
return
}
if apex, ok := mctx.Module().(*apexBundle); ok && apex.checkStrictUpdatabilityLinting(mctx) {
- mctx.WalkDeps(func(child, parent android.Module) bool {
- // b/208656169 Do not propagate strict updatability linting to libcore/
- // These libs are available on the classpath during compilation
- // These libs are transitive deps of the sdk. See java/sdk.go:decodeSdkDep
- // Only skip libraries defined in libcore root, not subdirectories
- if mctx.OtherModuleDir(child) == "libcore" {
- // Do not traverse transitive deps of libcore/ libs
+ apex.WalkPayloadDeps(mctx, func(mctx android.BaseModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
+ if externalDep {
return false
}
- if android.InList(child.Name(), skipLintJavalibAllowlist) {
- return false
- }
- if lintable, ok := child.(java.LintDepSetsIntf); ok {
+ if lintable, ok := to.(java.LintDepSetsIntf); ok {
lintable.SetStrictUpdatabilityLinting(true)
}
// visit transitive deps
@@ -1203,17 +1195,6 @@ var (
"test_jitzygote_com.android.art",
// go/keep-sorted end
}
-
- // TODO: b/215736885 Remove this list
- skipLintJavalibAllowlist = []string{
- "conscrypt.module.platform.api.stubs",
- "conscrypt.module.public.api.stubs",
- "conscrypt.module.public.api.stubs.system",
- "conscrypt.module.public.api.stubs.module_lib",
- "framework-media.stubs",
- "framework-media.stubs.system",
- "framework-media.stubs.module_lib",
- }
)
func (a *apexBundle) checkStrictUpdatabilityLinting(mctx android.TopDownMutatorContext) bool {