summaryrefslogtreecommitdiff
path: root/android
diff options
context:
space:
mode:
author Inseob Kim <inseob@google.com> 2025-03-14 18:33:55 +0900
committer Inseob Kim <inseob@google.com> 2025-03-14 02:51:29 -0700
commit0c67c8ed894dfece5035d28e3c6a0eca6c799495 (patch)
treefd1a03aeab9dcd778027e7a86f7e5cae6cb6ec83 /android
parent5509f0867e4bb4857cc93ee5ae7b9c2697af81b8 (diff)
Move requiredDeps to OverridableDepsMutator
Required properties can be overridden too. This adds requiredDeps in OverridablePropertiesDepsMutator for modules like override_apex. Bug: 398089235 Test: m nothing --no-skip-soong-tests Test: boot cuttlefish, TH Change-Id: I996543764b86136b8f8ae4427f5f977c7ac6553b
Diffstat (limited to 'android')
-rw-r--r--android/module.go10
-rw-r--r--android/override_module.go1
2 files changed, 10 insertions, 1 deletions
diff --git a/android/module.go b/android/module.go
index c6c4fd838..2bdf49a95 100644
--- a/android/module.go
+++ b/android/module.go
@@ -1002,11 +1002,19 @@ func (m *ModuleBase) baseDepsMutator(ctx BottomUpMutatorContext) {
pv := ctx.Config().productVariables
fullManifest := pv.DeviceArch != nil && pv.DeviceName != nil
if fullManifest {
- addRequiredDeps(ctx)
addVintfFragmentDeps(ctx)
}
}
+// required property can be overridden too; handle it separately
+func (m *ModuleBase) baseOverridablePropertiesDepsMutator(ctx BottomUpMutatorContext) {
+ pv := ctx.Config().productVariables
+ fullManifest := pv.DeviceArch != nil && pv.DeviceName != nil
+ if fullManifest {
+ addRequiredDeps(ctx)
+ }
+}
+
// addRequiredDeps adds required, target_required, and host_required as dependencies.
func addRequiredDeps(ctx BottomUpMutatorContext) {
addDep := func(target Target, depName string) {
diff --git a/android/override_module.go b/android/override_module.go
index 50ddc9b35..96620ef7a 100644
--- a/android/override_module.go
+++ b/android/override_module.go
@@ -367,6 +367,7 @@ func checkPrebuiltReplacesOverride(ctx BottomUpMutatorContext, b OverridableModu
}
func overridableModuleDepsMutator(ctx BottomUpMutatorContext) {
+ ctx.Module().base().baseOverridablePropertiesDepsMutator(ctx)
if b, ok := ctx.Module().(OverridableModule); ok && b.Enabled(ctx) {
b.OverridablePropertiesDepsMutator(ctx)
}