summaryrefslogtreecommitdiff
path: root/android/testing.go
diff options
context:
space:
mode:
author Jingwen Chen <jingwen@google.com> 2020-11-23 00:22:30 -0500
committer Jingwen Chen <jingwen@google.com> 2020-11-23 00:29:18 -0500
commitcda22c9bb92a5fc4fa5063103afde34805161c7a (patch)
treef7304d81543a6c3319ce32ca71639241dc718ddd /android/testing.go
parentb26070efef296bdd26c9d2ddadd0b4083587c484 (diff)
Refactor 'in_make' to mean Kati is not skipped.
In Nougat and before, Make wrote a marker file to indicate that soong_build was invoked from Make to change certain behaviors of Soong at build time. https://cs.android.com/android/platform/superproject/+/android-7.1.2_r36:build/core/soong.mk;l=70-73;drc=ae18638b0406ad107b0882a02a13cdd8b92f2a4e Things have changed, and now soong_build is invoked from soong_ui, which supports a --skip-make configuration flag: https://cs.android.com/android/platform/superproject/+/master:build/soong/ui/build/build.go;l=31-33;drc=680387bf1d3ce7cbc77f535be7c42cec411b1687 Thus, the various remnants of 'EmbeddedInMake' and 'inMake' configuration are misleading, since soong_build is no longer invoked from Make. This CL refactors all instances to actually mean that Kati is enabled (not skipped with --skip-make), and will run after soong_build finishes, so Kati-specific behavior like the AndroidMk singleton should run. Test: TH presubmit Change-Id: I576ab8e54f99f5c8ddf9feaf9a828019b279e266
Diffstat (limited to 'android/testing.go')
-rw-r--r--android/testing.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/android/testing.go b/android/testing.go
index 1e2ae130a..6539063bc 100644
--- a/android/testing.go
+++ b/android/testing.go
@@ -424,8 +424,8 @@ func CheckErrorsAgainstExpectations(t *testing.T, errs []error, expectedErrorPat
}
-func SetInMakeForTests(config Config) {
- config.inMake = true
+func SetKatiEnabledForTests(config Config) {
+ config.katiEnabled = true
}
func AndroidMkEntriesForTest(t *testing.T, config Config, bpPath string, mod blueprint.Module) []AndroidMkEntries {