diff options
| author | 2018-06-21 13:03:07 -0700 | |
|---|---|---|
| committer | 2018-06-22 12:44:35 -0700 | |
| commit | 6b75360cbcc4c3e26507092cc910bf001465bef1 (patch) | |
| tree | c6510572cc8ba33338b9f85f1f9e663ae1c6859c /android/singleton.go | |
| parent | 5c733856bd8e16bbd739abc388fa8ac43f073c92 (diff) | |
Use WalkDeps instead of VisitDepsDepthFirst
VisitDepsDepthFirst is almost never correct, as it can't query
dependency tags of multiple dependencies between the same two modules.
Replace VisitDepsDepthFirst with WalkDeps in sanitize.go and
python.go. Also verify the dependency tag before continuing to
recurse to ensure that they don't recurse through genrules and into
unrelated modules.
Test: m checkbuild
Change-Id: I2f7560126f56b51a40ec39dfbdcc18b5891489f7
Diffstat (limited to 'android/singleton.go')
| -rw-r--r-- | android/singleton.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/android/singleton.go b/android/singleton.go index f577b0a3c..fa1efdc0f 100644 --- a/android/singleton.go +++ b/android/singleton.go @@ -50,7 +50,9 @@ type SingletonContext interface { VisitAllModules(visit func(Module)) VisitAllModulesIf(pred func(Module) bool, visit func(Module)) + // Deprecated: use WalkDeps instead to support multiple dependency tags on the same module VisitDepsDepthFirst(module Module, visit func(Module)) + // Deprecated: use WalkDeps instead to support multiple dependency tags on the same module VisitDepsDepthFirstIf(module Module, pred func(Module) bool, visit func(Module)) |