summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Patrice Arruda <patricearruda@google.com> 2020-10-19 11:20:21 -0700
committer Patrice Arruda <patricearruda@google.com> 2020-10-21 08:54:56 -0700
commit457c5d3426d97019f471dec0a06186d59a5f7b1f (patch)
treeeb61efedea28ca2bbbbd50845b467f9948418fe9
parentfec3bf2e2c4354c8a3b50d639a01caaa28454b85 (diff)
Rename time to event in Soong metrics system.
Several structs and files are named time which records the total execution of a traceable event. Soon, resource information of an executed process is collected during a build event so a more generic name is applied. Bug: b/169453825 Test: go test and m nothing. Checked the soong_metrics protobuf. Change-Id: I65a782603530d51018d6cc1192c18cfeef7566a0
-rw-r--r--ui/build/context.go4
-rw-r--r--ui/metrics/Android.bp4
-rw-r--r--ui/metrics/event.go (renamed from ui/metrics/time.go)16
-rw-r--r--ui/metrics/event_test.go (renamed from ui/metrics/time_test.go)6
-rw-r--r--ui/metrics/metrics.go8
5 files changed, 19 insertions, 19 deletions
diff --git a/ui/build/context.go b/ui/build/context.go
index 3945ce007..43e1e0faf 100644
--- a/ui/build/context.go
+++ b/ui/build/context.go
@@ -48,7 +48,7 @@ func (c ContextImpl) BeginTrace(name, desc string) {
c.Tracer.Begin(desc, c.Thread)
}
if c.Metrics != nil {
- c.Metrics.TimeTracer.Begin(name, desc, c.Thread)
+ c.Metrics.EventTracer.Begin(name, desc, c.Thread)
}
}
@@ -58,7 +58,7 @@ func (c ContextImpl) EndTrace() {
c.Tracer.End(c.Thread)
}
if c.Metrics != nil {
- c.Metrics.SetTimeMetrics(c.Metrics.TimeTracer.End(c.Thread))
+ c.Metrics.SetTimeMetrics(c.Metrics.EventTracer.End(c.Thread))
}
}
diff --git a/ui/metrics/Android.bp b/ui/metrics/Android.bp
index 8188a69e9..95c8f5c24 100644
--- a/ui/metrics/Android.bp
+++ b/ui/metrics/Android.bp
@@ -23,10 +23,10 @@ bootstrap_go_package {
],
srcs: [
"metrics.go",
- "time.go",
+ "event.go",
],
testSrcs: [
- "time_test.go",
+ "event_test.go",
],
}
diff --git a/ui/metrics/time.go b/ui/metrics/event.go
index 401656337..5a62847a5 100644
--- a/ui/metrics/time.go
+++ b/ui/metrics/event.go
@@ -25,7 +25,7 @@ import (
// for testing purpose only
var _now = now
-type timeEvent struct {
+type event struct {
desc string
name string
@@ -33,26 +33,26 @@ type timeEvent struct {
start time.Time
}
-type TimeTracer interface {
+type EventTracer interface {
Begin(name, desc string, thread tracer.Thread)
End(thread tracer.Thread) soong_metrics_proto.PerfInfo
}
-type timeTracerImpl struct {
- activeEvents []timeEvent
+type eventTracerImpl struct {
+ activeEvents []event
}
-var _ TimeTracer = &timeTracerImpl{}
+var _ EventTracer = &eventTracerImpl{}
func now() time.Time {
return time.Now()
}
-func (t *timeTracerImpl) Begin(name, desc string, _ tracer.Thread) {
- t.activeEvents = append(t.activeEvents, timeEvent{name: name, desc: desc, start: _now()})
+func (t *eventTracerImpl) Begin(name, desc string, _ tracer.Thread) {
+ t.activeEvents = append(t.activeEvents, event{name: name, desc: desc, start: _now()})
}
-func (t *timeTracerImpl) End(tracer.Thread) soong_metrics_proto.PerfInfo {
+func (t *eventTracerImpl) End(tracer.Thread) soong_metrics_proto.PerfInfo {
if len(t.activeEvents) < 1 {
panic("Internal error: No pending events for endAt to end!")
}
diff --git a/ui/metrics/time_test.go b/ui/metrics/event_test.go
index d73080ab2..6fc0b50d1 100644
--- a/ui/metrics/time_test.go
+++ b/ui/metrics/event_test.go
@@ -28,14 +28,14 @@ func TestEnd(t *testing.T) {
_now = func() time.Time { return startTime.Add(dur) }
defer func() { _now = initialNow }()
- timeTracer := &timeTracerImpl{}
- timeTracer.activeEvents = append(timeTracer.activeEvents, timeEvent{
+ eventTracer := &eventTracerImpl{}
+ eventTracer.activeEvents = append(eventTracer.activeEvents, event{
desc: "test",
name: "test",
start: startTime,
})
- perf := timeTracer.End(tracer.Thread(0))
+ perf := eventTracer.End(tracer.Thread(0))
if perf.GetRealTime() != uint64(dur.Nanoseconds()) {
t.Errorf("got %d, want %d nanoseconds for event duration", perf.GetRealTime(), dur.Nanoseconds())
}
diff --git a/ui/metrics/metrics.go b/ui/metrics/metrics.go
index 35d197628..7a3726bc2 100644
--- a/ui/metrics/metrics.go
+++ b/ui/metrics/metrics.go
@@ -36,14 +36,14 @@ const (
)
type Metrics struct {
- metrics soong_metrics_proto.MetricsBase
- TimeTracer TimeTracer
+ metrics soong_metrics_proto.MetricsBase
+ EventTracer EventTracer
}
func New() (metrics *Metrics) {
m := &Metrics{
- metrics: soong_metrics_proto.MetricsBase{},
- TimeTracer: &timeTracerImpl{},
+ metrics: soong_metrics_proto.MetricsBase{},
+ EventTracer: &eventTracerImpl{},
}
return m
}