summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Colin Cross <ccross@android.com> 2016-11-21 17:22:15 -0800
committer Colin Cross <ccross@android.com> 2016-11-22 15:41:08 -0800
commit2ee10a0659406495e118c17ed20a7c4064a9da7a (patch)
treeaaa6039b931fb23d7a334dd9d759ce4a7db2eda9
parent124fd9afbdb4781048ceef84cdf7f9186127d365 (diff)
genrule: expand $$ to $$
An escaped $ sign in an expanded string needs to be re-escaped so it can pass through to ninja. Test: m -j libLLVMObject Change-Id: I2f7890417fd6f534e6e21cace3d86ae9ef708ce5
-rw-r--r--android/expand.go2
-rw-r--r--android/expand_test.go8
2 files changed, 5 insertions, 5 deletions
diff --git a/android/expand.go b/android/expand.go
index 101318108..527c4ac6d 100644
--- a/android/expand.go
+++ b/android/expand.go
@@ -57,7 +57,7 @@ func getMapping(s string, mapping func(string) (string, error)) (string, int, er
}
return "", len(s), fmt.Errorf("missing )")
case '$':
- return s[0:1], 1, nil
+ return "$$", 1, nil
default:
i := strings.IndexFunc(s, unicode.IsSpace)
if i == 0 {
diff --git a/android/expand_test.go b/android/expand_test.go
index ca50b3982..128de8a4e 100644
--- a/android/expand_test.go
+++ b/android/expand_test.go
@@ -85,19 +85,19 @@ var expandTestCases = []struct {
},
{
in: "$$",
- out: "$",
+ out: "$$",
},
{
in: "$$(var1)",
- out: "$(var1)",
+ out: "$$(var1)",
},
{
in: "$$$(var1)",
- out: "$abc",
+ out: "$$abc",
},
{
in: "$(var1)$$",
- out: "abc$",
+ out: "abc$$",
},
{
in: "$(💩)",