summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2024-09-10 18:48:06 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2024-09-10 18:48:06 +0000
commit2545872a68298ecb20f66d2c74824729ac1d9fdb (patch)
tree2c57a0f7d7ce39aa15c749528f2defbe924d3fe1
parent58e82f6c9c1d97695aad75416b750355efb20e5d (diff)
parent8a847c409c14bfc73f222a74dec413080559c851 (diff)
Merge "Improve docs about //visibility:public" into main
-rw-r--r--sdk/update.go12
1 files changed, 7 insertions, 5 deletions
diff --git a/sdk/update.go b/sdk/update.go
index 9379f36cb..93bb861e9 100644
--- a/sdk/update.go
+++ b/sdk/update.go
@@ -1118,12 +1118,14 @@ func (s *snapshotBuilder) AddPrebuiltModule(member android.SdkMember, moduleType
// Since module sdks are generated from release branches and dropped to development
// branches, there might be a visibility skew between the sources and prebuilts
// of a specific module.
- // To reconcile this potential skew, change the visibility to public
+ // To reconcile this potential skew, change the visibility to public.
//
- // This is safe for (1) since these are stub libraries.
- // This is ok for (2) since these are host and test exports and are intended for
- // ART development.
- // TODO (b/361303067): This can be removed if ART uses full manifests.
+ // This means dependencies can bypass visibility restrictions when prebuilts are used, so we rely
+ // on source builds in CI to check them.
+ //
+ // TODO (b/361303067): This special case for category (2) can be removed if existing usages
+ // of host/test prebuilts of modules like conscrypt,tzdata,i18n are switched to source builds.
+ // It will also require ART switching to full manifests.
m.AddProperty("visibility", []string{"//visibility:public"})
}