diff options
author | 2019-04-17 21:47:37 +0900 | |
---|---|---|
committer | 2019-04-19 13:48:33 +0900 | |
commit | f2976304f70fe61b705300f309687317c90a84fb (patch) | |
tree | 340cecf0f11db41ee21de2eac2e05f262b9303a4 | |
parent | 3c4a9159c977af265bb082143c2de9a34eae6420 (diff) |
Fix: PathsForModuleSrc does not work for a replaced dependency
PathsForModuleSrc does not work if a source module is replaced with a
prebuilt module. This is because the function uses GetDirectDepWithTag
with the name of the original source module. Since the dependency is
replaced and the prebuilt module has the name "prebuilt_<name>", the
search always fails.
Fixing this by re-implementing GetDirectDep* functions inside Soong
using VisitDirectDep.
Bug: 130627486
Test: m
Change-Id: I68d52668283c429d5e93c7f2c81f6a8db1f24893
-rw-r--r-- | android/module.go | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/android/module.go b/android/module.go index 93966e16d..b12f0c107 100644 --- a/android/module.go +++ b/android/module.go @@ -1042,6 +1042,39 @@ func (a *androidModuleContext) validateAndroidModule(module blueprint.Module) Mo return aModule } +func (a *androidModuleContext) getDirectDepInternal(name string, tag blueprint.DependencyTag) (blueprint.Module, blueprint.DependencyTag) { + type dep struct { + mod blueprint.Module + tag blueprint.DependencyTag + } + var deps []dep + a.VisitDirectDepsBlueprint(func(m blueprint.Module) { + if aModule, _ := m.(Module); aModule != nil && aModule.base().BaseModuleName() == name { + returnedTag := a.ModuleContext.OtherModuleDependencyTag(aModule) + if tag == nil || returnedTag == tag { + deps = append(deps, dep{aModule, returnedTag}) + } + } + }) + if len(deps) == 1 { + return deps[0].mod, deps[0].tag + } else if len(deps) >= 2 { + panic(fmt.Errorf("Multiple dependencies having same BaseModuleName() %q found from %q", + name, a.ModuleName())) + } else { + return nil, nil + } +} + +func (a *androidModuleContext) GetDirectDepWithTag(name string, tag blueprint.DependencyTag) blueprint.Module { + m, _ := a.getDirectDepInternal(name, tag) + return m +} + +func (a *androidModuleContext) GetDirectDep(name string) (blueprint.Module, blueprint.DependencyTag) { + return a.getDirectDepInternal(name, nil) +} + func (a *androidModuleContext) VisitDirectDepsBlueprint(visit func(blueprint.Module)) { a.ModuleContext.VisitDirectDeps(visit) } |