summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jooyung Han <jooyung@google.com> 2020-02-27 13:31:56 +0900
committer Jooyung Han <jooyung@google.com> 2020-02-27 13:31:56 +0900
commite6436d7bf08c81032c54690e465026f858f30fdb (patch)
tree5ee16be94cfe15d4a0eda28198a5a29ab789bec7
parent21321efc66abcaa0e34f5ed5bb24ccaab3802b6b (diff)
apex: fix a test util (ensureExactContent)
ensureExactContent shouldn't return immediately when it finds a match from expected list of files. Bug: N/A Test: m nothing Change-Id: Ie15c811f9cfcae7ede28dee0fcf203cee24659a0
-rw-r--r--apex/apex_test.go14
1 files changed, 12 insertions, 2 deletions
diff --git a/apex/apex_test.go b/apex/apex_test.go
index 10fc8d6aa..d1d8d6491 100644
--- a/apex/apex_test.go
+++ b/apex/apex_test.go
@@ -1532,13 +1532,17 @@ func ensureExactContents(t *testing.T, ctx *android.TestContext, moduleName, var
var surplus []string
filesMatched := make(map[string]bool)
for _, file := range getFiles(t, ctx, moduleName, variant) {
+ mactchFound := false
for _, expected := range files {
if matched, _ := path.Match(expected, file.path); matched {
filesMatched[expected] = true
- return
+ mactchFound = true
+ break
}
}
- surplus = append(surplus, file.path)
+ if !mactchFound {
+ surplus = append(surplus, file.path)
+ }
}
if len(surplus) > 0 {
@@ -1605,8 +1609,10 @@ func TestVndkApexCurrent(t *testing.T) {
ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
"lib/libvndk.so",
"lib/libvndksp.so",
+ "lib/libc++.so",
"lib64/libvndk.so",
"lib64/libvndksp.so",
+ "lib64/libc++.so",
"etc/llndk.libraries.VER.txt",
"etc/vndkcore.libraries.VER.txt",
"etc/vndksp.libraries.VER.txt",
@@ -1666,6 +1672,8 @@ func TestVndkApexWithPrebuilt(t *testing.T) {
"lib/libvndk.so",
"lib/libvndk.arm.so",
"lib64/libvndk.so",
+ "lib/libc++.so",
+ "lib64/libc++.so",
"etc/*",
})
}
@@ -1877,6 +1885,8 @@ func TestVndkApexSkipsNativeBridgeSupportedModules(t *testing.T) {
ensureExactContents(t, ctx, "myapex", "android_common_image", []string{
"lib/libvndk.so",
"lib64/libvndk.so",
+ "lib/libc++.so",
+ "lib64/libc++.so",
"etc/*",
})
}