summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Anton Hansson <hansson@google.com> 2023-11-07 16:01:29 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2023-11-07 16:01:29 +0000
commitbf3e32d870a69608af720194647c24ecdb934e54 (patch)
tree7a65eb4f2055710cd1b6ab58ca867f448565d4ed
parent216ed6c9181d56f65ee8750ad0f3723f511737fe (diff)
parentfd1c0d2eaa0d1455ab4e710fb83f1142bded0b81 (diff)
Merge "Add a new flag to stop disabling lint errors" into main
-rw-r--r--java/sdk_library.go20
1 files changed, 13 insertions, 7 deletions
diff --git a/java/sdk_library.go b/java/sdk_library.go
index 1de89727f..ea451743b 100644
--- a/java/sdk_library.go
+++ b/java/sdk_library.go
@@ -618,6 +618,10 @@ type sdkLibraryProperties struct {
Api_lint struct {
// Enable api linting.
Enabled *bool
+
+ // If API lint is enabled, this flag controls whether a set of legitimate lint errors
+ // are turned off. The default is true.
+ Legacy_errors_allowed *bool
}
// TODO: determines whether to create HTML doc or not
@@ -1747,13 +1751,15 @@ func (module *SdkLibrary) createStubsSourcesAndApi(mctx android.DefaultableHookC
android.JoinWithPrefix(module.sdkLibraryProperties.Hidden_api_packages, " --hide-package "))
}
droidstubsArgs = append(droidstubsArgs, module.sdkLibraryProperties.Droiddoc_options...)
- disabledWarnings := []string{
- "BroadcastBehavior",
- "DeprecationMismatch",
- "HiddenSuperclass",
- "MissingPermission",
- "SdkConstant",
- "Todo",
+ disabledWarnings := []string{"HiddenSuperclass"}
+ if proptools.BoolDefault(module.sdkLibraryProperties.Api_lint.Legacy_errors_allowed, true) {
+ disabledWarnings = append(disabledWarnings,
+ "BroadcastBehavior",
+ "DeprecationMismatch",
+ "MissingPermission",
+ "SdkConstant",
+ "Todo",
+ )
}
droidstubsArgs = append(droidstubsArgs, android.JoinWithPrefix(disabledWarnings, "--hide "))