diff options
| author | 2020-10-19 15:01:09 +0000 | |
|---|---|---|
| committer | 2020-10-19 15:01:09 +0000 | |
| commit | b51d6d13a83413c2641caf28b8777df828cd3619 (patch) | |
| tree | 6a4fa66a0b2a790dd15c1354c06dd77ecb116bd8 | |
| parent | 509a9d35ac77b474088016327c21083239a4deb8 (diff) | |
| parent | e501bb4d48414b9bf45f31712d75bdf5e3faa789 (diff) | |
Merge "Expand visiblity error"
| -rw-r--r-- | android/visibility.go | 2 | ||||
| -rw-r--r-- | android/visibility_test.go | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/android/visibility.go b/android/visibility.go index 51d561120..503a02174 100644 --- a/android/visibility.go +++ b/android/visibility.go @@ -443,7 +443,7 @@ func visibilityRuleEnforcer(ctx TopDownMutatorContext) { rule := effectiveVisibilityRules(ctx.Config(), depQualified) if !rule.matches(qualified) { - ctx.ModuleErrorf("depends on %s which is not visible to this module", depQualified) + ctx.ModuleErrorf("depends on %s which is not visible to this module\nYou may need to add %q to its visibility", depQualified, "//"+ctx.ModuleDir()) } }) } diff --git a/android/visibility_test.go b/android/visibility_test.go index 9d9e57438..cb5ef35b3 100644 --- a/android/visibility_test.go +++ b/android/visibility_test.go @@ -731,7 +731,7 @@ var visibilityTests = []struct { }`), }, expectedErrors: []string{ - `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, + `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`, }, }, { @@ -760,7 +760,7 @@ var visibilityTests = []struct { }`), }, expectedErrors: []string{ - `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module`, + `module "libnamespace" variant "android_common": depends on //top:libexample which is not visible to this module\nYou may need to add "//namespace" to its visibility`, }, }, { |