summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Jooyung Han <jooyung@google.com> 2020-05-14 07:44:03 +0900
committer Jooyung Han <jooyung@google.com> 2020-05-14 07:44:03 +0900
commit98d63e1cc7057c2204ab1fdd303f70fbf45e47c4 (patch)
treed0fb12e4af5bf5f27172361e1163a3a7b4c072bb
parentbbc3fb780b859ccd2c4550a8bc6b87f36d64dfd9 (diff)
Remove ApexBundleDepsInfo.MinSdkVersion()
For java.AndroidApp app, app.MinSdkVersion() was selected from ApexBundleDepsInfo, not from java.Module. This caused app.MinSdkVersion() to return "" always. Besides, having two embeded fields and relying on depth to choose one of them makes it hard to read. Bug: 156537348 Test: m Change-Id: Ib525b2f5132c596db8e33492d0a565ea23e91d1c
-rw-r--r--android/apex.go12
1 files changed, 2 insertions, 10 deletions
diff --git a/android/apex.go b/android/apex.go
index 9056c3de7..75be15026 100644
--- a/android/apex.go
+++ b/android/apex.go
@@ -421,21 +421,15 @@ type ApexModuleDepInfo struct {
type DepNameToDepInfoMap map[string]ApexModuleDepInfo
type ApexBundleDepsInfo struct {
- minSdkVersion string
- flatListPath OutputPath
- fullListPath OutputPath
+ flatListPath OutputPath
+ fullListPath OutputPath
}
type ApexDepsInfoIntf interface {
- MinSdkVersion() string
FlatListPath() Path
FullListPath() Path
}
-func (d *ApexBundleDepsInfo) MinSdkVersion() string {
- return d.minSdkVersion
-}
-
func (d *ApexBundleDepsInfo) FlatListPath() Path {
return d.flatListPath
}
@@ -450,8 +444,6 @@ var _ ApexDepsInfoIntf = (*ApexBundleDepsInfo)(nil)
// 1. FullList with transitive deps and their parents in the dep graph
// 2. FlatList with a flat list of transitive deps
func (d *ApexBundleDepsInfo) BuildDepsInfoLists(ctx ModuleContext, minSdkVersion string, depInfos DepNameToDepInfoMap) {
- d.minSdkVersion = minSdkVersion
-
var fullContent strings.Builder
var flatContent strings.Builder