summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com> 2023-10-10 02:22:14 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2023-10-10 02:22:14 +0000
commit6525ee82d7fe84f274f9b4214c3ea3bb4426b02f (patch)
treea84069981294eca7ef02815058f551f5bd95f7ab
parent0f81762d3f7bdeeac7f0500da80ad59826fea0a4 (diff)
parent6e119745b8a8ec35ddcd2bba374c882d742002d2 (diff)
Merge "Revert "Do not convert non-unit tests."" into main
-rw-r--r--bp2build/cc_test_conversion_test.go20
-rw-r--r--cc/test.go8
2 files changed, 0 insertions, 28 deletions
diff --git a/bp2build/cc_test_conversion_test.go b/bp2build/cc_test_conversion_test.go
index 392a9621d..679a36461 100644
--- a/bp2build/cc_test_conversion_test.go
+++ b/bp2build/cc_test_conversion_test.go
@@ -631,23 +631,3 @@ cc_test {
},
})
}
-
-func TestCcTest_UnitTestFalse(t *testing.T) {
- runCcTestTestCase(t, ccTestBp2buildTestCase{
- description: "cc test with test_options.tags converted to tags",
- blueprint: `
-cc_test {
- name: "mytest",
- host_supported: true,
- srcs: ["test.cpp"],
- test_options: { unit_test: false },
-}
-` + simpleModule("cc_library_static", "libgtest_main") +
- simpleModule("cc_library_static", "libgtest"),
- stubbedBuildDefinitions: []string{
- "libgtest_main",
- "libgtest",
- },
- targets: []testBazelTarget{},
- })
-}
diff --git a/cc/test.go b/cc/test.go
index f128187d2..5b778dc87 100644
--- a/cc/test.go
+++ b/cc/test.go
@@ -25,7 +25,6 @@ import (
"android/soong/bazel"
"android/soong/bazel/cquery"
"android/soong/tradefed"
- "android/soong/ui/metrics/bp2build_metrics_proto"
)
// TestLinkerProperties properties to be registered via the linker
@@ -719,13 +718,6 @@ func testBinaryBp2build(ctx android.Bp2buildMutatorContext, m *Module) {
combinedData.Append(android.BazelLabelForModuleDeps(ctx, p.Data_libs))
data.SetSelectValue(axis, config, combinedData)
tags.SetSelectValue(axis, config, p.Test_options.Tags)
-
- // TODO: b/300117121 - handle bp2build conversion of non-unit tests
- // default to true to only handle non-nil falses
- if !BoolDefault(p.Test_options.Unit_test, true) {
- ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_PROPERTY_UNSUPPORTED, "Host unit_test = false")
- return
- }
}
}
}