summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kevin Liu <congxiliu@google.com> 2024-06-28 18:33:35 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> 2024-06-28 18:33:35 +0000
commit00c2b86d6263d1814ccd3218f2bcbbddcee5a2d5 (patch)
tree625c30360e44df0fe55e5a14b00134f65764daa7
parent6650b15953efe67f723ab9253992dc743ae3c799 (diff)
parent51349b87e976e66fe0d0886c4f009d084ba30e86 (diff)
Merge "Revert^2 "Set strict_mode to true"" into main
-rw-r--r--java/robolectric.go7
1 files changed, 5 insertions, 2 deletions
diff --git a/java/robolectric.go b/java/robolectric.go
index 18386c90c..cb22fa0db 100644
--- a/java/robolectric.go
+++ b/java/robolectric.go
@@ -116,7 +116,7 @@ func (r *robolectricTest) DepsMutator(ctx android.BottomUpMutatorContext) {
if v := String(r.robolectricProperties.Robolectric_prebuilt_version); v != "" {
ctx.AddVariationDependencies(nil, libTag, fmt.Sprintf(robolectricPrebuiltLibPattern, v))
- } else if !proptools.Bool(r.robolectricProperties.Strict_mode) {
+ } else if !proptools.BoolDefault(r.robolectricProperties.Strict_mode, true) {
if proptools.Bool(r.robolectricProperties.Upstream) {
ctx.AddVariationDependencies(nil, libTag, robolectricCurrentLib+"_upstream")
} else {
@@ -124,8 +124,11 @@ func (r *robolectricTest) DepsMutator(ctx android.BottomUpMutatorContext) {
}
}
- if proptools.Bool(r.robolectricProperties.Strict_mode) {
+ if proptools.BoolDefault(r.robolectricProperties.Strict_mode, true) {
ctx.AddVariationDependencies(nil, roboRuntimeOnlyTag, robolectricCurrentLib+"_upstream")
+ } else {
+ // opting out from strict mode, robolectric_non_strict_mode_permission lib should be added
+ ctx.AddVariationDependencies(nil, libTag, "robolectric_non_strict_mode_permission")
}
ctx.AddVariationDependencies(nil, libTag, robolectricDefaultLibs...)