summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Cole Faust <colefaust@google.com> 2025-01-07 11:15:01 -0800
committer Cole Faust <colefaust@google.com> 2025-01-07 11:15:01 -0800
commit000d8f81a6926dd8c45803fef4eaedce065f0cb5 (patch)
tree0574bcf4eaab98e558085262ed16e0dca0494f80
parent5f09297fdf7538ddc9aad5e9b0eecfe184592538 (diff)
Remove printfs in tests
So that we don't get as much garbage output when running tests. Test: m nothing --no-skip-soong-tests Change-Id: I4be3097eb02e5167ac0902c1de983e17decb0e23
-rw-r--r--aconfig/all_aconfig_declarations.go5
-rw-r--r--ui/metrics/proc/status_linux_test.go2
2 files changed, 3 insertions, 4 deletions
diff --git a/aconfig/all_aconfig_declarations.go b/aconfig/all_aconfig_declarations.go
index 6ad54da4a..3262493c3 100644
--- a/aconfig/all_aconfig_declarations.go
+++ b/aconfig/all_aconfig_declarations.go
@@ -65,15 +65,16 @@ func (this *allAconfigDeclarationsSingleton) GenerateBuildActions(ctx android.Si
})
var numOffendingPkg = 0
+ offendingPkgsMessage := ""
for pkg, cnt := range packages {
if cnt > 1 {
- fmt.Printf("%d aconfig_declarations found for package %s\n", cnt, pkg)
+ offendingPkgsMessage += fmt.Sprintf("%d aconfig_declarations found for package %s\n", cnt, pkg)
numOffendingPkg++
}
}
if numOffendingPkg > 0 {
- panic(fmt.Errorf("Only one aconfig_declarations allowed for each package."))
+ panic("Only one aconfig_declarations allowed for each package.\n" + offendingPkgsMessage)
}
// Generate build action for aconfig (binary proto output)
diff --git a/ui/metrics/proc/status_linux_test.go b/ui/metrics/proc/status_linux_test.go
index 67098502b..0edc40031 100644
--- a/ui/metrics/proc/status_linux_test.go
+++ b/ui/metrics/proc/status_linux_test.go
@@ -1,7 +1,6 @@
package proc
import (
- "fmt"
"path/filepath"
"reflect"
"strconv"
@@ -29,7 +28,6 @@ func TestNewProcStatus(t *testing.T) {
t.Fatalf("got %v, want nil for error", err)
}
- fmt.Printf("%d %d\b", status.VmPeak, expectedStatus.VmPeak)
if !reflect.DeepEqual(status, expectedStatus) {
t.Errorf("got %v, expecting %v for ProcStatus", status, expectedStatus)
}