From 98b285dafb90b7136dadc55c534888e7155205b1 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 28 Apr 2021 14:49:32 -0700 Subject: Fix/suppress most pylint and gpylint warnings * Add missing function doc strings. Suppress this warning on trivial functions in *_warn_patterns.py. * Remove unused g-importing-memeber, g-complex-comprehension. * Suppress pylint warning on unrecognized g-* options. * Suppress too-few-public-methods warnings on simple classes. * Suppress too-many-arguments and missing-function-docstring in html_writer.py, which will be refactored later. * Fix bad naming, long lines and line breaks, and bad quotes. Test: compare output for build.log Change-Id: Icdb34f014a10ec1e642c2cfe8003fc3ae245b507 --- tools/warn/java_warn_patterns.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'tools/warn/java_warn_patterns.py') diff --git a/tools/warn/java_warn_patterns.py b/tools/warn/java_warn_patterns.py index ac1ed5d9be..534f48d2cd 100644 --- a/tools/warn/java_warn_patterns.py +++ b/tools/warn/java_warn_patterns.py @@ -15,8 +15,10 @@ """Warning patterns for Java compiler tools.""" +# No need of doc strings for trivial small functions. +# pylint:disable=missing-function-docstring + # pylint:disable=relative-beyond-top-level -# pylint:disable=g-importing-member from .cpp_warn_patterns import compile_patterns from .severity import Severity @@ -59,7 +61,8 @@ def low(name, description=None): warn_patterns = [ - # pylint:disable=line-too-long,g-inconsistent-quotes + # pylint does not recognize g-inconsistent-quotes + # pylint:disable=line-too-long,bad-option-value,g-inconsistent-quotes # Warnings from Javac java_medium('Use of deprecated', [r'.*: warning: \[deprecation\] .+', -- cgit v1.2.3-59-g8ed1b