From 0c6a2fac775f179a533320dd521332760f998ea8 Mon Sep 17 00:00:00 2001 From: MÃ¥rten Kongstad Date: Thu, 14 Dec 2023 13:56:25 +0100 Subject: aconfig: pass ownership of ProtoParsedFlag items to Java codegen Pass ownership of the ProtoParsedFlag iterator items to the Java codegen: this removes the need for an explicit lifetime annotation. Bug: N/A Test: atest aconfig.test Change-Id: I78705b65b4cf41c3e23b59afbd122a029ee45df4 --- tools/aconfig/src/codegen/java.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'tools/aconfig/src/codegen/java.rs') diff --git a/tools/aconfig/src/codegen/java.rs b/tools/aconfig/src/codegen/java.rs index ae3f274648..1d5dabf9f6 100644 --- a/tools/aconfig/src/codegen/java.rs +++ b/tools/aconfig/src/codegen/java.rs @@ -24,16 +24,16 @@ use crate::codegen; use crate::commands::{CodegenMode, OutputFile}; use crate::protos::{ProtoFlagPermission, ProtoFlagState, ProtoParsedFlag}; -pub fn generate_java_code<'a, I>( +pub fn generate_java_code( package: &str, parsed_flags_iter: I, codegen_mode: CodegenMode, ) -> Result> where - I: Iterator, + I: Iterator, { let flag_elements: Vec = - parsed_flags_iter.map(|pf| create_flag_element(package, pf)).collect(); + parsed_flags_iter.map(|pf| create_flag_element(package, &pf)).collect(); let exported_flag_elements: Vec = flag_elements.iter().filter(|elem| elem.exported).cloned().collect(); let namespace_flags = gen_flags_by_namespace(&flag_elements); @@ -361,7 +361,7 @@ mod tests { let parsed_flags = crate::test::parse_test_flags(); let generated_files = generate_java_code( crate::test::TEST_PACKAGE, - parsed_flags.parsed_flag.iter(), + parsed_flags.parsed_flag.into_iter(), CodegenMode::Production, ) .unwrap(); @@ -514,7 +514,7 @@ mod tests { let parsed_flags = crate::test::parse_test_flags(); let generated_files = generate_java_code( crate::test::TEST_PACKAGE, - parsed_flags.parsed_flag.iter(), + parsed_flags.parsed_flag.into_iter(), CodegenMode::Exported, ) .unwrap(); @@ -705,7 +705,7 @@ mod tests { let parsed_flags = crate::test::parse_test_flags(); let generated_files = generate_java_code( crate::test::TEST_PACKAGE, - parsed_flags.parsed_flag.iter(), + parsed_flags.parsed_flag.into_iter(), CodegenMode::Test, ) .unwrap(); -- cgit v1.2.3-59-g8ed1b