diff options
| author | 2020-06-05 22:28:20 -0700 | |
|---|---|---|
| committer | 2020-06-10 17:18:05 -0700 | |
| commit | e88ef9299ad647f5a1da16213efd25e7adfc1c10 (patch) | |
| tree | bea2e7b0c09e6f836f2bb1a00677ab1f2d962a35 /tools/warn/java_warn_patterns.py | |
| parent | fff4e1f5a4a17177bac5595ee1c84faacfa4694b (diff) | |
Rewrite test data logic to make it faster
It turns out we have a few tests with thousands of test data files,
which this logic does not handle very well. Just switching from `x :=
$(x) ...` to `x += ...` accomplishes the majority of these gains, but I
rewrote the logic to be less function-call+eval based to hopefully make
it easier to understand.
For an aosp-master/aosp_coral-eng build, this brings the time spent in
this logic from 7.6s to 0.3s (total kati runtime of 54s to 46s). Kati's
peak memory use (maxrss) also shrunk from 6.1GB to 3.8GB.
Bug: 158488548
Test: build-aosp_coral.ninja is the same before/after
Change-Id: Ia2ec8b29b5c1dd12fa7ea10b4f80fe802c692725
Merged-In: Ia2ec8b29b5c1dd12fa7ea10b4f80fe802c692725
(cherry picked from commit c5ec8e95bc11083d3edd034379c624467c687c31)
Diffstat (limited to 'tools/warn/java_warn_patterns.py')
0 files changed, 0 insertions, 0 deletions