diff options
| author | 2021-06-01 16:03:22 -0700 | |
|---|---|---|
| committer | 2021-06-02 21:34:49 +0000 | |
| commit | 5d9ee04f569232f3eadbdae214058c87225145cc (patch) | |
| tree | cb6bac32c910a2d30955f8c97e87fcf008055e92 /tools/warn/java_warn_patterns.py | |
| parent | 54b437286b6f2d7827ab4c099710661da467189e (diff) | |
Add new Asm/C++/Java/Make warning patterns
* Change some incorrectly-classified logtags warnings to C++.
* Fix gpylint warnings of long lines in html_writer.py.
Test: warn.py --url=http://cs/android --separator='?l=' build.log > warnings.html
Test: warn.py --gencsv build.log > warnings.csv
Change-Id: I98c01dadfd72b202d81ef7c94e93c42182f6065c
Diffstat (limited to 'tools/warn/java_warn_patterns.py')
| -rw-r--r-- | tools/warn/java_warn_patterns.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tools/warn/java_warn_patterns.py b/tools/warn/java_warn_patterns.py index 534f48d2cd..7dfa8668b7 100644 --- a/tools/warn/java_warn_patterns.py +++ b/tools/warn/java_warn_patterns.py @@ -74,6 +74,8 @@ warn_patterns = [ [r'.*\.class\): warning: Cannot find annotation method .+ in']), java_medium('No class/method in SDK ...', [r'.*\.java:.*: warning: No such (class|method) .* for SDK']), + java_medium('Unknown enum constant', + [r'unknown_source_file: warning: unknown enum constant .+']), # Warnings generated by Error Prone java_medium('Non-ascii characters used, but ascii encoding specified', [r".*: warning: unmappable character for encoding ascii"]), @@ -207,6 +209,8 @@ warn_patterns = [ 'Logging or rethrowing exceptions should usually be preferred to catching and calling printStackTrace'), medium('CatchFail', 'Ignoring exceptions and calling fail() is unnecessary, and makes test output less useful'), + medium('ChangedAbstract', + 'Method has changed \'abstract\' qualifier'), medium('ClassCanBeStatic', 'Inner class is non-static but does not reference enclosing class'), medium('ClassNewInstance', @@ -355,6 +359,8 @@ warn_patterns = [ 'equals method doesn\'t override Object.equals'), medium('NotCloseable', 'Not closeable'), + medium('NullableCollection', + 'Method should not return a nullable collection'), medium('NullableConstructor', 'Constructors should not be annotated with @Nullable since they cannot return null'), medium('NullableDereference', |