summaryrefslogtreecommitdiff
path: root/tools/warn/cpp_warn_patterns.py
diff options
context:
space:
mode:
author Jooyung Han <jooyung@google.com> 2019-07-22 15:31:55 +0900
committer Jooyung Han <jooyung@google.com> 2019-07-22 15:31:55 +0900
commit0fbfb4bd571847629c9c42e37571171321e6d38b (patch)
tree07b6605e39599031af596012797f681a30cb99c4 /tools/warn/cpp_warn_patterns.py
parent97f75df31cb16f7cb9c480ea08a63e43dde43a09 (diff)
fix: set built_module in misc_prebuilt_internal.mk
*_prebuilt_internal.mk should set "built_module" with LOCAL_BUILT_MODULE on success, since it is used to set dependency between built module and additional dependencies (LOCAL_ADDITIONAL_DEPENDENCIES). In aosp/970424, it didn't set it properly. As a consequence, setting additional dependencies to a built module was wrong for various classes of modules(ETC, SCRIPT, DATA) For example, prebuilt_etc_xml module(com.google.vr.platform.xml) has an additional depdendency(timestamp of xmllint). But the dependency is set to unexected module(com.android.support.apexer.soong_zip). This is because that 1) built_module is not set in misc_prebuilt_internal.mk 2) built_module is not reset after use and soong_zip was last module which set built_module variable. Bug: 132925121 Test: m com.google.vr.platform.xml && check build-<TARGET>.ninja to see if there is additional dependency as described above Change-Id: I74fdf6b6ad583f3c08dc0b8fc8595d7ef9cc7306
Diffstat (limited to 'tools/warn/cpp_warn_patterns.py')
0 files changed, 0 insertions, 0 deletions