diff options
| author | 2023-10-06 07:28:44 +0000 | |
|---|---|---|
| committer | 2023-10-10 13:55:06 +0000 | |
| commit | 22a90f4f10a39a64ad785fa5444fc396d4e9d8e2 (patch) | |
| tree | a12c9278ca9b3b696fb0611cabd0904d2828ffe7 /tools/aconfig/src/codegen_java.rs | |
| parent | e52ce13e82fcb0fba1574e54704e992021469d2e (diff) | |
aconfig: add @UnsupportedAppUsage to methods in generated flags
The java generated flags are marked as @hide which breaks CTS. To
unblock CTS test add @UnsupportedAppUsage to expose the methods.
Test: atest aconfig.test.flags
Bug: 301272559
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:64ad75f50ae96f9a8b57a9e8f88ae9a53d3c1044)
Merged-In: I897573c054e70fc6e093869ba6d416c38f81e28f
Change-Id: I897573c054e70fc6e093869ba6d416c38f81e28f
Diffstat (limited to 'tools/aconfig/src/codegen_java.rs')
| -rw-r--r-- | tools/aconfig/src/codegen_java.rs | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/tools/aconfig/src/codegen_java.rs b/tools/aconfig/src/codegen_java.rs index c4fc405a61..43c2ecfc36 100644 --- a/tools/aconfig/src/codegen_java.rs +++ b/tools/aconfig/src/codegen_java.rs @@ -118,21 +118,30 @@ mod tests { const EXPECTED_FEATUREFLAGS_COMMON_CONTENT: &str = r#" package com.android.aconfig.test; + // TODO(b/303773055): Remove the annotation after access issue is resolved. + import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public interface FeatureFlags { @com.android.aconfig.annotations.AssumeFalseForR8 + @UnsupportedAppUsage boolean disabledRo(); + @UnsupportedAppUsage boolean disabledRw(); @com.android.aconfig.annotations.AssumeTrueForR8 + @UnsupportedAppUsage boolean enabledFixedRo(); @com.android.aconfig.annotations.AssumeTrueForR8 + @UnsupportedAppUsage boolean enabledRo(); + @UnsupportedAppUsage boolean enabledRw(); } "#; const EXPECTED_FLAG_COMMON_CONTENT: &str = r#" package com.android.aconfig.test; + // TODO(b/303773055): Remove the annotation after access issue is resolved. + import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public final class Flags { /** @hide */ @@ -147,20 +156,25 @@ mod tests { public static final String FLAG_ENABLED_RW = "com.android.aconfig.test.enabled_rw"; @com.android.aconfig.annotations.AssumeFalseForR8 + @UnsupportedAppUsage public static boolean disabledRo() { return FEATURE_FLAGS.disabledRo(); } + @UnsupportedAppUsage public static boolean disabledRw() { return FEATURE_FLAGS.disabledRw(); } @com.android.aconfig.annotations.AssumeTrueForR8 + @UnsupportedAppUsage public static boolean enabledFixedRo() { return FEATURE_FLAGS.enabledFixedRo(); } @com.android.aconfig.annotations.AssumeTrueForR8 + @UnsupportedAppUsage public static boolean enabledRo() { return FEATURE_FLAGS.enabledRo(); } + @UnsupportedAppUsage public static boolean enabledRw() { return FEATURE_FLAGS.enabledRw(); } @@ -168,6 +182,8 @@ mod tests { const EXPECTED_FAKEFEATUREFLAGSIMPL_CONTENT: &str = r#" package com.android.aconfig.test; + // TODO(b/303773055): Remove the annotation after access issue is resolved. + import android.compat.annotation.UnsupportedAppUsage; import java.util.HashMap; import java.util.Map; /** @hide */ @@ -176,22 +192,27 @@ mod tests { resetAll(); } @Override + @UnsupportedAppUsage public boolean disabledRo() { return getValue(Flags.FLAG_DISABLED_RO); } @Override + @UnsupportedAppUsage public boolean disabledRw() { return getValue(Flags.FLAG_DISABLED_RW); } @Override + @UnsupportedAppUsage public boolean enabledFixedRo() { return getValue(Flags.FLAG_ENABLED_FIXED_RO); } @Override + @UnsupportedAppUsage public boolean enabledRo() { return getValue(Flags.FLAG_ENABLED_RO); } @Override + @UnsupportedAppUsage public boolean enabledRw() { return getValue(Flags.FLAG_ENABLED_RW); } @@ -241,14 +262,18 @@ mod tests { let expect_featureflagsimpl_content = r#" package com.android.aconfig.test; + // TODO(b/303773055): Remove the annotation after access issue is resolved. + import android.compat.annotation.UnsupportedAppUsage; import android.provider.DeviceConfig; /** @hide */ public final class FeatureFlagsImpl implements FeatureFlags { @Override + @UnsupportedAppUsage public boolean disabledRo() { return false; } @Override + @UnsupportedAppUsage public boolean disabledRw() { return getValue( "aconfig_test", @@ -257,14 +282,17 @@ mod tests { ); } @Override + @UnsupportedAppUsage public boolean enabledFixedRo() { return true; } @Override + @UnsupportedAppUsage public boolean enabledRo() { return true; } @Override + @UnsupportedAppUsage public boolean enabledRw() { return getValue( "aconfig_test", @@ -346,29 +374,36 @@ mod tests { "#; let expect_featureflagsimpl_content = r#" package com.android.aconfig.test; + // TODO(b/303773055): Remove the annotation after access issue is resolved. + import android.compat.annotation.UnsupportedAppUsage; /** @hide */ public final class FeatureFlagsImpl implements FeatureFlags { @Override + @UnsupportedAppUsage public boolean disabledRo() { throw new UnsupportedOperationException( "Method is not implemented."); } @Override + @UnsupportedAppUsage public boolean disabledRw() { throw new UnsupportedOperationException( "Method is not implemented."); } @Override + @UnsupportedAppUsage public boolean enabledFixedRo() { throw new UnsupportedOperationException( "Method is not implemented."); } @Override + @UnsupportedAppUsage public boolean enabledRo() { throw new UnsupportedOperationException( "Method is not implemented."); } @Override + @UnsupportedAppUsage public boolean enabledRw() { throw new UnsupportedOperationException( "Method is not implemented."); |