summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
author Kelvin Zhang <zhangkelvin@google.com> 2024-01-19 11:04:58 -0800
committer Kelvin Zhang <zhangkelvin@google.com> 2024-01-19 11:04:58 -0800
commit12ac11025ed96eadd1497c7dfed5b889d34fa8a3 (patch)
tree71165f4719e521e17a8d1c5133b7928bc7a79324
parent04591b6315b64c3d3805a6ee874bd11abd3851f3 (diff)
Fix signing failures on targets with >4GB target_files
An old python zipfile hack prevented zipfile module from decoding 64 bit sizes correctly, remove the legacy hack to fix. Test: check_target_files_signatures -v 5GB_target_files.zip Bug: 319367048 Change-Id: I376c7b68f549ddf88680280d604548d1849cdfe2
-rwxr-xr-xtools/releasetools/check_target_files_signatures.py16
1 files changed, 0 insertions, 16 deletions
diff --git a/tools/releasetools/check_target_files_signatures.py b/tools/releasetools/check_target_files_signatures.py
index a7b35230ea..cdafb4b2e5 100755
--- a/tools/releasetools/check_target_files_signatures.py
+++ b/tools/releasetools/check_target_files_signatures.py
@@ -58,22 +58,6 @@ if sys.hexversion < 0x02070000:
logger = logging.getLogger(__name__)
-# Work around a bug in Python's zipfile module that prevents opening of zipfiles
-# if any entry has an extra field of between 1 and 3 bytes (which is common with
-# zipaligned APKs). This overrides the ZipInfo._decodeExtra() method (which
-# contains the bug) with an empty version (since we don't need to decode the
-# extra field anyway).
-# Issue #14315: https://bugs.python.org/issue14315, fixed in Python 2.7.8 and
-# Python 3.5.0 alpha 1.
-
-
-class MyZipInfo(zipfile.ZipInfo):
- def _decodeExtra(self):
- pass
-
-
-zipfile.ZipInfo = MyZipInfo
-
OPTIONS = common.OPTIONS