1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
|
/*
* Copyright (C) 2015 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
public class Main {
/*
* Ensure an inlined static invoke explicitly triggers the
* initialization check of the called method's declaring class, and
* that the corresponding load class instruction does not get
* removed before register allocation & code generation.
*/
/// CHECK-START: void Main.invokeStaticInlined() builder (after)
/// CHECK-DAG: <<LoadClass:l\d+>> LoadClass gen_clinit_check:false
/// CHECK-DAG: <<ClinitCheck:l\d+>> ClinitCheck [<<LoadClass>>]
/// CHECK-DAG: InvokeStaticOrDirect [{{[ij]\d+}},<<ClinitCheck>>]
/// CHECK-START: void Main.invokeStaticInlined() inliner (after)
/// CHECK-DAG: <<LoadClass:l\d+>> LoadClass gen_clinit_check:false
/// CHECK-DAG: <<ClinitCheck:l\d+>> ClinitCheck [<<LoadClass>>]
/// CHECK-START: void Main.invokeStaticInlined() inliner (after)
/// CHECK-NOT: InvokeStaticOrDirect
// The following checks ensure the clinit check instruction added by
// the builder is pruned by the PrepareForRegisterAllocation, while
// the load class instruction is preserved. As the control flow
// graph is not dumped after (nor before) this step, we check the
// CFG as it is before the next pass (liveness analysis) instead.
/// CHECK-START: void Main.invokeStaticInlined() liveness (before)
/// CHECK-DAG: LoadClass gen_clinit_check:true
/// CHECK-START: void Main.invokeStaticInlined() liveness (before)
/// CHECK-NOT: ClinitCheck
/// CHECK-NOT: InvokeStaticOrDirect
static void invokeStaticInlined() {
ClassWithClinit1.$opt$inline$StaticMethod();
}
static class ClassWithClinit1 {
static {
System.out.println("Main$ClassWithClinit1's static initializer");
}
static void $opt$inline$StaticMethod() {
}
}
/*
* Ensure a non-inlined static invoke eventually has an implicit
* initialization check of the called method's declaring class.
*/
/// CHECK-START: void Main.invokeStaticNotInlined() builder (after)
/// CHECK: <<LoadClass:l\d+>> LoadClass gen_clinit_check:false
/// CHECK: <<ClinitCheck:l\d+>> ClinitCheck [<<LoadClass>>]
/// CHECK: InvokeStaticOrDirect [{{[ij]\d+}},<<ClinitCheck>>]
/// CHECK-START: void Main.invokeStaticNotInlined() inliner (after)
/// CHECK: <<LoadClass:l\d+>> LoadClass gen_clinit_check:false
/// CHECK: <<ClinitCheck:l\d+>> ClinitCheck [<<LoadClass>>]
/// CHECK: InvokeStaticOrDirect [{{([ij]\d+,)?}}<<ClinitCheck>>]
// The following checks ensure the clinit check and load class
// instructions added by the builder are pruned by the
// PrepareForRegisterAllocation. As the control flow graph is not
// dumped after (nor before) this step, we check the CFG as it is
// before the next pass (liveness analysis) instead.
/// CHECK-START: void Main.invokeStaticNotInlined() liveness (before)
/// CHECK: InvokeStaticOrDirect
/// CHECK-START: void Main.invokeStaticNotInlined() liveness (before)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
static void invokeStaticNotInlined() {
ClassWithClinit2.$noinline$staticMethod();
}
static class ClassWithClinit2 {
static {
System.out.println("Main$ClassWithClinit2's static initializer");
}
static boolean doThrow = false;
static void $noinline$staticMethod() {
if (doThrow) {
// Try defeating inlining.
throw new Error();
}
}
}
/*
* Ensure an inlined call to a static method whose declaring class
* is statically known to have been initialized does not require an
* explicit clinit check.
*/
/// CHECK-START: void Main$ClassWithClinit3.invokeStaticInlined() builder (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$ClassWithClinit3.invokeStaticInlined() builder (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-START: void Main$ClassWithClinit3.invokeStaticInlined() inliner (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-NOT: InvokeStaticOrDirect
static class ClassWithClinit3 {
static void invokeStaticInlined() {
// The invocation of invokeStaticInlined triggers the
// initialization of ClassWithClinit3, meaning that the
// hereinbelow call to $opt$inline$StaticMethod does not need a
// clinit check.
$opt$inline$StaticMethod();
}
static {
System.out.println("Main$ClassWithClinit3's static initializer");
}
static void $opt$inline$StaticMethod() {
}
}
/*
* Ensure an non-inlined call to a static method whose declaring
* class is statically known to have been initialized does not
* require an explicit clinit check.
*/
/// CHECK-START: void Main$ClassWithClinit4.invokeStaticNotInlined() builder (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$ClassWithClinit4.invokeStaticNotInlined() builder (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-START: void Main$ClassWithClinit4.invokeStaticNotInlined() inliner (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$ClassWithClinit4.invokeStaticNotInlined() inliner (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
static class ClassWithClinit4 {
static void invokeStaticNotInlined() {
// The invocation of invokeStaticNotInlined triggers the
// initialization of ClassWithClinit4, meaning that the
// call to staticMethod below does not need a clinit
// check.
$noinline$staticMethod();
}
static {
System.out.println("Main$ClassWithClinit4's static initializer");
}
static boolean doThrow = false;
static void $noinline$staticMethod() {
if (doThrow) {
// Try defeating inlining.
throw new Error();
}
}
}
/*
* Ensure an inlined call to a static method whose declaring class
* is a super class of the caller's class does not require an
* explicit clinit check.
*/
/// CHECK-START: void Main$SubClassOfClassWithClinit5.invokeStaticInlined() builder (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$SubClassOfClassWithClinit5.invokeStaticInlined() builder (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-START: void Main$SubClassOfClassWithClinit5.invokeStaticInlined() inliner (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-NOT: InvokeStaticOrDirect
static class ClassWithClinit5 {
static void $opt$inline$StaticMethod() {
}
static {
System.out.println("Main$ClassWithClinit5's static initializer");
}
}
static class SubClassOfClassWithClinit5 extends ClassWithClinit5 {
static void invokeStaticInlined() {
ClassWithClinit5.$opt$inline$StaticMethod();
}
}
/*
* Ensure an non-inlined call to a static method whose declaring
* class is a super class of the caller's class does not require an
* explicit clinit check.
*/
/// CHECK-START: void Main$SubClassOfClassWithClinit6.invokeStaticNotInlined() builder (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$SubClassOfClassWithClinit6.invokeStaticNotInlined() builder (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
/// CHECK-START: void Main$SubClassOfClassWithClinit6.invokeStaticNotInlined() inliner (after)
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main$SubClassOfClassWithClinit6.invokeStaticNotInlined() inliner (after)
/// CHECK-NOT: LoadClass
/// CHECK-NOT: ClinitCheck
static class ClassWithClinit6 {
static boolean doThrow = false;
static void $noinline$staticMethod() {
if (doThrow) {
// Try defeating inlining.
throw new Error();
}
}
static {
System.out.println("Main$ClassWithClinit6's static initializer");
}
}
static class SubClassOfClassWithClinit6 extends ClassWithClinit6 {
static void invokeStaticNotInlined() {
ClassWithClinit6.$noinline$staticMethod();
}
}
/*
* Verify that if we have a static call immediately after the load class
* we don't do generate a clinit check.
*/
/// CHECK-START: void Main.noClinitBecauseOfInvokeStatic() liveness (before)
/// CHECK-DAG: <<IntConstant:i\d+>> IntConstant 0
/// CHECK-DAG: <<LoadClass:l\d+>> LoadClass gen_clinit_check:false
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-DAG: StaticFieldSet [<<LoadClass>>,<<IntConstant>>]
/// CHECK-START: void Main.noClinitBecauseOfInvokeStatic() liveness (before)
/// CHECK-NOT: ClinitCheck
static void noClinitBecauseOfInvokeStatic() {
ClassWithClinit2.$noinline$staticMethod();
ClassWithClinit2.doThrow = false;
}
/*
* Verify that if the static call is after a field access, the load class
* will generate a clinit check.
*/
/// CHECK-START: void Main.clinitBecauseOfFieldAccess() liveness (before)
/// CHECK-DAG: <<IntConstant:i\d+>> IntConstant 0
/// CHECK-DAG: <<LoadClass:l\d+>> LoadClass gen_clinit_check:true
/// CHECK-DAG: StaticFieldSet [<<LoadClass>>,<<IntConstant>>]
/// CHECK-DAG: InvokeStaticOrDirect
/// CHECK-START: void Main.clinitBecauseOfFieldAccess() liveness (before)
/// CHECK-NOT: ClinitCheck
static void clinitBecauseOfFieldAccess() {
ClassWithClinit2.doThrow = false;
ClassWithClinit2.$noinline$staticMethod();
}
// TODO: Add a test for the case of a static method whose declaring
// class type index is not available (i.e. when `storage_index`
// equals `DexFile::kDexNoIndex` in
// art::HGraphBuilder::BuildInvoke).
public static void main(String[] args) {
invokeStaticInlined();
invokeStaticNotInlined();
ClassWithClinit3.invokeStaticInlined();
ClassWithClinit4.invokeStaticNotInlined();
SubClassOfClassWithClinit5.invokeStaticInlined();
SubClassOfClassWithClinit6.invokeStaticNotInlined();
}
}
|