From e19d74b51ad8efd43c1583887cbde123ae769f7b Mon Sep 17 00:00:00 2001 From: David Srbecky Date: Wed, 2 Nov 2022 11:27:08 +0000 Subject: Run-tests: Fix/implement --update; avoid stdout patching. The update has never worked reliably, but with the separation of the `sed` and `diff` it is getting much better now. Avoid stdout patching to improve --update mode further. The tests still have stdout that differs based on flags. Support those by having multiple (full) expected files. Test: test.py -r --all-target --all-jvmti --all-prebuild \ -t 1931 -t 1932 -t 1936 -t 1950 -t 1953 \ -t 1954 -t 1955 -t 1956 -t 1969 -t 909 Change-Id: I070037717f9964755492b42b6efd52179deb4125 --- test/909-attach-agent/run.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'test/909-attach-agent/run.py') diff --git a/test/909-attach-agent/run.py b/test/909-attach-agent/run.py index 9050ce77ac..1e35ec98e5 100644 --- a/test/909-attach-agent/run.py +++ b/test/909-attach-agent/run.py @@ -22,8 +22,7 @@ def run(ctx, args): if args.interpreter: # On interpreter we are fully capable of providing the full jvmti api so we # have a slightly different expected output. - # TODO We should really be changing this in the 'check' script. - ctx.run("patch -s expected-stdout.txt