From 83426160568b62b22a1f1559cace78b5152c7749 Mon Sep 17 00:00:00 2001
From: Logan Chien <loganchien@google.com>
Date: Fri, 9 Dec 2011 09:29:50 +0800
Subject: Cleanup "Beginning of LLVM backend for ART."

Change-Id: I290e4d46b880256b6bf2eae7b3c828ee8d7595f2
---
 src/compiler_llvm/ir_builder.cc | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

(limited to 'src/compiler_llvm/ir_builder.cc')

diff --git a/src/compiler_llvm/ir_builder.cc b/src/compiler_llvm/ir_builder.cc
index ea773bd5fd..24fac1a46d 100644
--- a/src/compiler_llvm/ir_builder.cc
+++ b/src/compiler_llvm/ir_builder.cc
@@ -18,7 +18,8 @@
 
 #include <llvm/Module.h>
 
-using namespace art::compiler_llvm;
+namespace art {
+namespace compiler_llvm {
 
 
 //----------------------------------------------------------------------------
@@ -78,9 +79,13 @@ llvm::Type* IRBuilder::getJTypeInAccurateSpace(JType jty) {
 
 
 llvm::Type* IRBuilder::getJTypeInRegSpace(JType jty) {
-  switch (GetRegCategoryFromJType(jty)) {
+  RegCategory regcat = GetRegCategoryFromJType(jty);
+
+  switch (regcat) {
   case kRegUnknown:
   case kRegZero:
+    LOG(FATAL) << "Register category \"Unknown\" or \"Zero\" does not have "
+               << "the LLVM type";
     return NULL;
 
   case kRegCat1nr:
@@ -93,6 +98,7 @@ llvm::Type* IRBuilder::getJTypeInRegSpace(JType jty) {
     return getJObjectTy();
   }
 
+  LOG(FATAL) << "Unknown register category: " << regcat;
   return NULL;
 }
 
@@ -100,6 +106,7 @@ llvm::Type* IRBuilder::getJTypeInRegSpace(JType jty) {
 llvm::Type* IRBuilder::getJTypeInArraySpace(JType jty) {
   switch (jty) {
   case kVoid:
+    LOG(FATAL) << "void type should not be used in array type space";
     return NULL;
 
   case kBoolean:
@@ -126,5 +133,10 @@ llvm::Type* IRBuilder::getJTypeInArraySpace(JType jty) {
     return getJObjectTy();
   }
 
+  LOG(FATAL) << "Unknown java type: " << jty;
   return NULL;
 }
+
+
+} // namespace compiler_llvm
+} // namespace art
-- 
cgit v1.2.3-59-g8ed1b