From 647b1a86f518d8db0331b3d52a96392b7a62504b Mon Sep 17 00:00:00 2001 From: Ian Rogers Date: Fri, 10 Oct 2014 11:02:11 -0700 Subject: Fix 2 new sets of clang compiler warnings. Fix issues that are flagged by -Wfloat-equal and -Wmissing-noreturn. In the case of -Wfloat-equal the current cases in regular code are deliberate, so the change is to silence the warning. For gtest code the appropriate fix is to switch from EXPECT_EQ to EXPECT_(FLOAT|DOUBLE)_EQ. The -Wmissing-noreturn warning isn't enabled due to a missing noreturn in gtest. This issue has been reported to gtest. Change-Id: Id84c70c21c542716c9ee0c41492e8ff8788c4ef8 --- runtime/parsed_options_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'runtime/parsed_options_test.cc') diff --git a/runtime/parsed_options_test.cc b/runtime/parsed_options_test.cc index 5154d69292..61481b16e6 100644 --- a/runtime/parsed_options_test.cc +++ b/runtime/parsed_options_test.cc @@ -64,7 +64,7 @@ TEST_F(ParsedOptionsTest, ParsedOptions) { EXPECT_EQ(2048U, parsed->heap_initial_size_); EXPECT_EQ(4 * KB, parsed->heap_maximum_size_); EXPECT_EQ(1 * MB, parsed->stack_size_); - EXPECT_EQ(0.75, parsed->heap_target_utilization_); + EXPECT_DOUBLE_EQ(0.75, parsed->heap_target_utilization_); EXPECT_TRUE(test_vfprintf == parsed->hook_vfprintf_); EXPECT_TRUE(test_exit == parsed->hook_exit_); EXPECT_TRUE(test_abort == parsed->hook_abort_); -- cgit v1.2.3-59-g8ed1b