From e34fa1df67fbe0173b4ea9abddcc3ae3d0537037 Mon Sep 17 00:00:00 2001 From: Mathieu Chartier Date: Wed, 14 Jan 2015 14:55:47 -0800 Subject: Print more info in MarkSweep::VerifyRoot Refactored old root callback to use a new class called RootInfo. RootInfo contains all the relevant info related to the root associated with the callback. The MarkSweep::VerifyRoot function now uses this info to print the StackVisitor's described location if the GC root is of the type kRootJavaFrame. Some other cleanup. Example output: E/art (12167): Tried to mark 0x123 not contained by any spaces E/art (12167): Attempting see if it's a bad root E/art (12167): Found invalid root: 0x123 with type RootJavaFrame E/art (12167): Location=Visiting method 'void java.lang.Runtime.gc()' at dex PC 0xffffffff (native PC 0x0) vreg=0 (cherry picked from commit 12f7423a2bb4bfab76700d84eb6d4338d211983a) Bug: 18588862 Change-Id: Ic5a2781f704e931265ffb3621c2eab4b2e25f60f --- runtime/mirror/reference.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'runtime/mirror/reference.cc') diff --git a/runtime/mirror/reference.cc b/runtime/mirror/reference.cc index c36bd980f9..35130e8b88 100644 --- a/runtime/mirror/reference.cc +++ b/runtime/mirror/reference.cc @@ -33,9 +33,7 @@ void Reference::ResetClass() { } void Reference::VisitRoots(RootCallback* callback, void* arg) { - if (!java_lang_ref_Reference_.IsNull()) { - java_lang_ref_Reference_.VisitRoot(callback, arg, 0, kRootStickyClass); - } + java_lang_ref_Reference_.VisitRootIfNonNull(callback, arg, RootInfo(kRootStickyClass)); } } // namespace mirror -- cgit v1.2.3-59-g8ed1b