From 29ec7aef84f4b47d89edee274562b22a177b00b8 Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Wed, 6 Apr 2022 09:30:50 +0000 Subject: Use `std::string_view` for `ClassTable` operations. Use `std::string_view` instead of `const char*` descriptor. This uses faster `memcmp` instead of the slower`strcmp` for descriptor comparison. Note that the `ScopedTrace` passes `const char*` across the `libartpalette` boundary, so we cannot easily replace the `const char* descriptor` with `std::string_view descriptor` in certain `ClassLinker` functions because we actually need to pass a null-terminated string and the `string_view` API does not technically guarantee null-terminated data. Therefore we resort to explicitly passing around the descriptor and its length as separate arguments. Test: m test-art-host-gtest Test: testrunner.py --host --optimizing Bug: 181943478 Bug: 338123769 Change-Id: Ie3fa251390acc582c54b4686d18696eb89b32361 --- runtime/class_table.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'runtime/class_table.cc') diff --git a/runtime/class_table.cc b/runtime/class_table.cc index 35d3537478..5a20c2f576 100644 --- a/runtime/class_table.cc +++ b/runtime/class_table.cc @@ -104,7 +104,7 @@ size_t ClassTable::NumReferencedNonZygoteClasses() const { return classes_.back().size(); } -ObjPtr ClassTable::Lookup(const char* descriptor, size_t hash) { +ObjPtr ClassTable::Lookup(std::string_view descriptor, size_t hash) { DescriptorHashPair pair(descriptor, hash); ReaderMutexLock mu(Thread::Current(), lock_); // Search from the last table, assuming that apps shall search for their own classes -- cgit v1.2.3-59-g8ed1b