From 7d8d8ff0727a7aa9d11c738f13a7e06d3c4c3d68 Mon Sep 17 00:00:00 2001 From: Nicolas Geoffray Date: Wed, 2 Nov 2016 12:38:05 +0000 Subject: Revert "Revert "ART: Generalize FindClassInPathClassLoader"" Bug: 32510706 Change is not responsible for the flakiness after all. This reverts commit af3572bc21cf66f970090c852b976095bb028083. Change-Id: I399049c217deeac6a5c3f9d678a46bdb84386e3f --- runtime/class_linker.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'runtime/class_linker.h') diff --git a/runtime/class_linker.h b/runtime/class_linker.h index 3248d0e3d9..4426056078 100644 --- a/runtime/class_linker.h +++ b/runtime/class_linker.h @@ -794,17 +794,17 @@ class ClassLinker { void FixupStaticTrampolines(ObjPtr klass) REQUIRES_SHARED(Locks::mutator_lock_); - // Finds a class in the path class loader, loading it if necessary without using JNI. Hash + // Finds a class in a Path- or DexClassLoader, loading it if necessary without using JNI. Hash // function is supposed to be ComputeModifiedUtf8Hash(descriptor). Returns true if the // class-loader chain could be handled, false otherwise, i.e., a non-supported class-loader // was encountered while walking the parent chain (currently only BootClassLoader and // PathClassLoader are supported). - bool FindClassInPathClassLoader(ScopedObjectAccessAlreadyRunnable& soa, - Thread* self, - const char* descriptor, - size_t hash, - Handle class_loader, - ObjPtr* result) + bool FindClassInBaseDexClassLoader(ScopedObjectAccessAlreadyRunnable& soa, + Thread* self, + const char* descriptor, + size_t hash, + Handle class_loader, + ObjPtr* result) REQUIRES_SHARED(Locks::mutator_lock_) REQUIRES(!dex_lock_); @@ -1200,7 +1200,7 @@ class ClassLinker { friend struct CompilationHelper; // For Compile in ImageTest. friend class ImageDumper; // for DexLock friend class ImageWriter; // for GetClassRoots - friend class VMClassLoader; // for LookupClass and FindClassInPathClassLoader. + friend class VMClassLoader; // for LookupClass and FindClassInBaseDexClassLoader. friend class JniCompilerTest; // for GetRuntimeQuickGenericJniStub friend class JniInternalTest; // for GetRuntimeQuickGenericJniStub ART_FRIEND_TEST(ClassLinkerTest, RegisterDexFileName); // for DexLock, and RegisterDexFileLocked -- cgit v1.2.3-59-g8ed1b