From 6e8977690147b75096c0a993efb53ae329e3fd2c Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Tue, 16 Oct 2018 13:09:32 -0700 Subject: ART: Refactor for bugprone-argument-comment Handles openjdkjvmti. Bug: 116054210 Test: WITH_TIDY=1 mmma art Change-Id: Ic73e3f32b08f3b6d9300428ad95d12a696db0458 --- openjdkjvmti/ti_heap.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'openjdkjvmti/ti_heap.cc') diff --git a/openjdkjvmti/ti_heap.cc b/openjdkjvmti/ti_heap.cc index 6c79a602c3..559ee0d427 100644 --- a/openjdkjvmti/ti_heap.cc +++ b/openjdkjvmti/ti_heap.cc @@ -981,7 +981,9 @@ class FollowReferencesHelper final { // TODO: We don't have this info. if (thread != nullptr) { ref_info->jni_local.depth = 0; - art::ArtMethod* method = thread->GetCurrentMethod(nullptr, false /* abort_on_error */); + art::ArtMethod* method = thread->GetCurrentMethod(nullptr, + /* check_suspended= */ true, + /* abort_on_error= */ false); if (method != nullptr) { ref_info->jni_local.method = art::jni::EncodeArtMethod(method); } @@ -1012,7 +1014,7 @@ class FollowReferencesHelper final { ref_info->stack_local.slot = static_cast(java_info.GetVReg()); const art::StackVisitor* visitor = java_info.GetVisitor(); ref_info->stack_local.location = - static_cast(visitor->GetDexPc(false /* abort_on_failure */)); + static_cast(visitor->GetDexPc(/* abort_on_failure= */ false)); ref_info->stack_local.depth = static_cast(visitor->GetFrameDepth()); art::ArtMethod* method = visitor->GetMethod(); if (method != nullptr) { @@ -1447,7 +1449,7 @@ jvmtiError HeapUtil::GetLoadedClasses(jvmtiEnv* env, } jvmtiError HeapUtil::ForceGarbageCollection(jvmtiEnv* env ATTRIBUTE_UNUSED) { - art::Runtime::Current()->GetHeap()->CollectGarbage(/* clear_soft_references */ false); + art::Runtime::Current()->GetHeap()->CollectGarbage(/* clear_soft_references= */ false); return ERR(NONE); } -- cgit v1.2.3-59-g8ed1b