From 3f3ac2c75b1cef76ef2af73371880cce8ec43455 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Tue, 7 May 2024 16:55:00 -0700 Subject: Use isolated: true instead of test_per_src: true in libnativebridge_tests libnativebridge_tests uses test_per_src: true to avoid running multiple tests in the same process. gtest_isolated uses separate processes for each test, but without the various incompatibilities caused by test_per_src. Switch to isolated: true instead. Create a temporary directory in the constructor of the shared NativeBridgeTest base class instead and put the code_cache directory inside it to keep the tests from trying to modify the current directory. Also add the tests to TEST_MAPPING and remove the preupload check. Bug: 189484095 Test: atest --host libnativebridge_tests Test: atest libnativebridge_tests Flag: TEST_ONLY Change-Id: Iea522c1895f1f5996b10e545c44d6b00bda1ee3d --- libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp') diff --git a/libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp b/libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp index db7dd31cfb..2b709e05ab 100644 --- a/libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp +++ b/libnativebridge/tests/NativeBridge3CreateNamespace_test.cpp @@ -22,7 +22,7 @@ TEST_F(NativeBridgeTest, V3_CreateNamespace) { // Init ASSERT_TRUE(LoadNativeBridge(kNativeBridgeLibrary3, nullptr)); ASSERT_TRUE(NativeBridgeAvailable()); - ASSERT_TRUE(PreInitializeNativeBridge(".", "isa")); + ASSERT_TRUE(PreInitializeNativeBridge(appDataDir(), "isa")); ASSERT_TRUE(NativeBridgeAvailable()); ASSERT_TRUE(InitializeNativeBridge(nullptr, nullptr)); ASSERT_TRUE(NativeBridgeAvailable()); @@ -32,7 +32,7 @@ TEST_F(NativeBridgeTest, V3_CreateNamespace) { 0, nullptr, nullptr)); // Clean-up code_cache - ASSERT_EQ(0, rmdir(kCodeCache)); + ASSERT_EQ(0, rmdir(codeCache())); } } // namespace android -- cgit v1.2.3-59-g8ed1b