From 3c04974a90b0e03f4b509010bff49f0b2a3da57f Mon Sep 17 00:00:00 2001 From: Nicolas Geoffray Date: Wed, 24 Sep 2014 18:10:46 +0100 Subject: Optimize suspend checks in optimizing compiler. - Remove the ones added during graph build (they were added for the baseline code generator). - Emit them at loop back edges after phi moves, so that the test can directly jump to the loop header. - Fix x86 and x86_64 suspend check by using cmpw instead of cmpl. Change-Id: I6fad5795a55705d86c9e1cb85bf5d63dadfafa2a --- compiler/utils/x86/assembler_x86.cc | 8 ++++++++ compiler/utils/x86/assembler_x86.h | 2 ++ 2 files changed, 10 insertions(+) (limited to 'compiler/utils/x86') diff --git a/compiler/utils/x86/assembler_x86.cc b/compiler/utils/x86/assembler_x86.cc index 2c9bc28923..f888d46dd1 100644 --- a/compiler/utils/x86/assembler_x86.cc +++ b/compiler/utils/x86/assembler_x86.cc @@ -746,6 +746,7 @@ void X86Assembler::xchgl(Register dst, Register src) { EmitRegisterOperand(dst, src); } + void X86Assembler::xchgl(Register reg, const Address& address) { AssemblerBuffer::EnsureCapacity ensured(&buffer_); EmitUint8(0x87); @@ -753,6 +754,13 @@ void X86Assembler::xchgl(Register reg, const Address& address) { } +void X86Assembler::cmpw(const Address& address, const Immediate& imm) { + AssemblerBuffer::EnsureCapacity ensured(&buffer_); + EmitUint8(0x66); + EmitComplex(7, address, imm); +} + + void X86Assembler::cmpl(Register reg, const Immediate& imm) { AssemblerBuffer::EnsureCapacity ensured(&buffer_); EmitComplex(7, Operand(reg), imm); diff --git a/compiler/utils/x86/assembler_x86.h b/compiler/utils/x86/assembler_x86.h index 5c4e34fc8b..ec983d9a50 100644 --- a/compiler/utils/x86/assembler_x86.h +++ b/compiler/utils/x86/assembler_x86.h @@ -337,6 +337,8 @@ class X86Assembler FINAL : public Assembler { void xchgl(Register dst, Register src); void xchgl(Register reg, const Address& address); + void cmpw(const Address& address, const Immediate& imm); + void cmpl(Register reg, const Immediate& imm); void cmpl(Register reg0, Register reg1); void cmpl(Register reg, const Address& address); -- cgit v1.2.3-59-g8ed1b