From ccf15bca330f9a23337b1a4b5850f7fcc6c1bf15 Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Tue, 23 Aug 2016 17:48:38 +0000 Subject: Revert "x86/x86-64: Avoid temporary for read barrier field load." Fault handler does not recognize the instruction F6 /0 ib TEST r/m8, imm8 so we get crashes instead of NPEs. Bug: 29966877 Bug: 12687968 This reverts commit ccf06d8f19a37432de4a3b768747090adfbd18ec. Change-Id: Ib7db3b59f44c0d3ed5e24a20b6c6ee596a89d709 --- compiler/utils/x86/assembler_x86.cc | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'compiler/utils/x86/assembler_x86.cc') diff --git a/compiler/utils/x86/assembler_x86.cc b/compiler/utils/x86/assembler_x86.cc index f2ef41f400..f1a991574b 100644 --- a/compiler/utils/x86/assembler_x86.cc +++ b/compiler/utils/x86/assembler_x86.cc @@ -1148,23 +1148,6 @@ void X86Assembler::testl(Register reg, const Immediate& immediate) { } -void X86Assembler::testb(const Address& dst, const Immediate& imm) { - AssemblerBuffer::EnsureCapacity ensured(&buffer_); - EmitUint8(0xF6); - EmitOperand(EAX, dst); - CHECK(imm.is_int8()); - EmitUint8(imm.value() & 0xFF); -} - - -void X86Assembler::testl(const Address& dst, const Immediate& imm) { - AssemblerBuffer::EnsureCapacity ensured(&buffer_); - EmitUint8(0xF7); - EmitOperand(0, dst); - EmitImmediate(imm); -} - - void X86Assembler::andl(Register dst, Register src) { AssemblerBuffer::EnsureCapacity ensured(&buffer_); EmitUint8(0x23); -- cgit v1.2.3-59-g8ed1b