From 80afd02024d20e60b197d3adfbb43cc303cf29e0 Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Tue, 19 May 2015 18:08:00 +0100 Subject: ART: Clean up arm64 kNumberOfXRegisters usage. Avoid undefined behavior for arm64 stemming from 1u << 32 in loops with upper bound kNumberOfXRegisters. Create iterators for enumerating bits in an integer either from high to low or from low to high and use them for Context::FillCalleeSaves() on all architectures. Refactor runtime/utils.{h,cc} by moving all bit-fiddling functions to runtime/base/bit_utils.{h,cc} (together with the new bit iterators) and all time-related functions to runtime/base/time_utils.{h,cc}. Improve test coverage and fix some corner cases for the bit-fiddling functions. Bug: 13925192 Change-Id: I704884dab15b41ecf7a1c47d397ab1c3fc7ee0f7 --- compiler/utils/assembler_test_base.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'compiler/utils/assembler_test_base.h') diff --git a/compiler/utils/assembler_test_base.h b/compiler/utils/assembler_test_base.h index 3341151c8b..574051a657 100644 --- a/compiler/utils/assembler_test_base.h +++ b/compiler/utils/assembler_test_base.h @@ -17,14 +17,15 @@ #ifndef ART_COMPILER_UTILS_ASSEMBLER_TEST_BASE_H_ #define ART_COMPILER_UTILS_ASSEMBLER_TEST_BASE_H_ -#include "common_runtime_test.h" // For ScratchFile - #include #include #include #include #include +#include "common_runtime_test.h" // For ScratchFile +#include "utils.h" + namespace art { // If you want to take a look at the differences between the ART assembler and GCC, set this flag -- cgit v1.2.3-59-g8ed1b