From 54e15de4a3ea869488d50694fa01138901e70c4e Mon Sep 17 00:00:00 2001 From: Andreas Gampe Date: Wed, 6 Aug 2014 15:31:06 -0700 Subject: ART: Make assembler_test less chatty Do not save temporaries in case we use a different encoding than the host assembler. Bug: 16505797 Change-Id: Iaa9edfe8bc84d7f809f5b403de902b92b0998431 --- compiler/utils/assembler_test.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'compiler/utils/assembler_test.h') diff --git a/compiler/utils/assembler_test.h b/compiler/utils/assembler_test.h index 05ac70ed74..37429131ef 100644 --- a/compiler/utils/assembler_test.h +++ b/compiler/utils/assembler_test.h @@ -361,12 +361,15 @@ class AssemblerTest : public testing::Test { } else { if (DisassembleBinaries(*data, *res.code, test_name)) { if (data->size() > res.code->size()) { - LOG(WARNING) << "Assembly code is not identical, but disassembly of machine code is " - "equal: this implies sub-optimal encoding! Our code size=" << data->size() << + // Fail this test with a fancy colored warning being printed. + EXPECT_TRUE(false) << "Assembly code is not identical, but disassembly of machine code " + "is equal: this implies sub-optimal encoding! Our code size=" << data->size() << ", gcc size=" << res.code->size(); } else { + // Otherwise just print an info message and clean up. LOG(INFO) << "GCC chose a different encoding than ours, but the overall length is the " "same."; + Clean(&res); } } else { // This will output the assembly. -- cgit v1.2.3-59-g8ed1b