From c992e42601a9dc99a8ddcaecbc7f9d5048d77a38 Mon Sep 17 00:00:00 2001
From: Andra Danciu <andradanciu@google.com>
Date: Wed, 16 Sep 2020 08:12:02 +0000
Subject: X86: Clarify HandleFieldSet constant volatile Float64 case

In case of a constant Float64 value code generation, we ensure that the
field is not volatile.

Test: art/test.py --host --all-compiler --optimizing --32 -r
Change-Id: I512c89dffc446fd9a44d2f409c6d2ddac756e111
---
 compiler/optimizing/code_generator_x86.cc | 1 +
 1 file changed, 1 insertion(+)

(limited to 'compiler/optimizing')

diff --git a/compiler/optimizing/code_generator_x86.cc b/compiler/optimizing/code_generator_x86.cc
index ceeadb305c..4a0eb2e42e 100644
--- a/compiler/optimizing/code_generator_x86.cc
+++ b/compiler/optimizing/code_generator_x86.cc
@@ -5813,6 +5813,7 @@ void InstructionCodeGeneratorX86::HandleFieldSet(HInstruction* instruction,
 
     case DataType::Type::kFloat64: {
       if (value.IsConstant()) {
+        DCHECK(!is_volatile);
         int64_t v = CodeGenerator::GetInt64ValueOf(value.GetConstant());
         __ movl(Address(base, offset), Immediate(Low32Bits(v)));
         codegen_->MaybeRecordImplicitNullCheck(instruction);
-- 
cgit v1.2.3-59-g8ed1b