From b03ab575b9acb3fd73861d5d0a7719dcd0a6322a Mon Sep 17 00:00:00 2001 From: Nicolas Geoffray Date: Mon, 17 Feb 2025 14:18:17 +0000 Subject: Only locking error and runtime throws should retrigger verification. This ensures the stability of the vdex file. Test: 412-new-array Change-Id: I73a6be0a46b6eb184ea127de720bfaf7104f3777 --- compiler/optimizing/instruction_builder.cc | 2 -- 1 file changed, 2 deletions(-) (limited to 'compiler/optimizing') diff --git a/compiler/optimizing/instruction_builder.cc b/compiler/optimizing/instruction_builder.cc index 74880463c3..8cc79c2424 100644 --- a/compiler/optimizing/instruction_builder.cc +++ b/compiler/optimizing/instruction_builder.cc @@ -2554,8 +2554,6 @@ bool HInstructionBuilder::BuildFilledNewArray(uint32_t dex_pc, char primitive = descriptor[1]; if (primitive != 'I' && primitive != 'L' && primitive != '[') { DCHECK(primitive != 'J' && primitive != 'D'); // Rejected by the verifier. - // FIXME: Why do we JIT compile a method with `VERIFY_ERROR_FILLED_NEW_ARRAY` when - // `CanCompilerHandleVerificationFailure(VERIFY_ERROR_FILLED_NEW_ARRAY)` returns false? MaybeRecordStat(compilation_stats_, MethodCompilationStat::kNotCompiledMalformedOpcode); return false; } -- cgit v1.2.3-59-g8ed1b