From 8d34a182fea1b24f7b8361b55e930cb953cf3fb2 Mon Sep 17 00:00:00 2001 From: Nicolas Geoffray Date: Wed, 16 Sep 2020 09:46:58 +0100 Subject: Change interface conflict stub to take the interface method. To avoid doing dex cache lookup, pass the interface method instead. This costs a few hundred KBs on speed compiled APKs (< 0.5% code size), but improves performance when hitting a conflict (as seen on dogfood data). For nterp, we currently pass the conflict method instead of the interface method. We need to handle default methods before optimizing it. This removes our last use of dex cache in compiled code. A follow-up CL will remove the NeedsDexCacheOfDeclaringClass from HInvokeInterface. Test: test.py Change-Id: I3cdd4543ad7d904b3e81950af46a48a48af6991a --- compiler/optimizing/sharpening.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'compiler/optimizing/sharpening.cc') diff --git a/compiler/optimizing/sharpening.cc b/compiler/optimizing/sharpening.cc index f570c60843..3ffb24b852 100644 --- a/compiler/optimizing/sharpening.cc +++ b/compiler/optimizing/sharpening.cc @@ -57,7 +57,7 @@ static bool BootImageAOTCanEmbedMethod(ArtMethod* method, const CompilerOptions& return compiler_options.IsImageClass(dex_file.StringByTypeIdx(klass->GetDexTypeIndex())); } -HInvokeStaticOrDirect::DispatchInfo HSharpening::SharpenInvokeStaticOrDirect( +HInvokeStaticOrDirect::DispatchInfo HSharpening::SharpenLoadMethod( ArtMethod* callee, bool has_method_id, CodeGenerator* codegen) { if (kIsDebugBuild) { ScopedObjectAccess soa(Thread::Current()); // Required for GetDeclaringClass below. -- cgit v1.2.3-59-g8ed1b