From c9ea8725f4e71d3014850c066736d991d0f2d4bd Mon Sep 17 00:00:00 2001 From: Vladimir Marko Date: Fri, 23 Aug 2024 16:05:19 +0200 Subject: Add LSE gtests for inserting type conversions. Add tests for the cases where the LSE correctly inserts the required type conversion instructions as needed, as well as tests for currently broken cases. The latter are guarded by `GTEST_SKIP()` until we fix them in a separate change. Test: m test-art-host-gtest Bug: 341476044 Change-Id: Id6002bc31cef542564b84258defcab45b06e6445 --- compiler/optimizing/optimizing_unit_test.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'compiler/optimizing/optimizing_unit_test.h') diff --git a/compiler/optimizing/optimizing_unit_test.h b/compiler/optimizing/optimizing_unit_test.h index f4f62e67ed..2fe11299fc 100644 --- a/compiler/optimizing/optimizing_unit_test.h +++ b/compiler/optimizing/optimizing_unit_test.h @@ -507,22 +507,22 @@ class OptimizingUnitTestHelper { } HInstanceFieldSet* MakeIFieldSet(HBasicBlock* block, - HInstruction* inst, + HInstruction* object, HInstruction* data, MemberOffset off, uint32_t dex_pc = kNoDexPc) { CHECK(data != nullptr); - return MakeIFieldSet(block, inst, data, data->GetType(), off, dex_pc); + return MakeIFieldSet(block, object, data, data->GetType(), off, dex_pc); } HInstanceFieldSet* MakeIFieldSet(HBasicBlock* block, - HInstruction* inst, + HInstruction* object, HInstruction* data, DataType::Type field_type, MemberOffset off, uint32_t dex_pc = kNoDexPc) { HInstanceFieldSet* ifield_set = new (GetAllocator()) HInstanceFieldSet( - inst, + object, data, /* field= */ nullptr, field_type, @@ -537,12 +537,12 @@ class OptimizingUnitTestHelper { } HInstanceFieldGet* MakeIFieldGet(HBasicBlock* block, - HInstruction* inst, + HInstruction* object, DataType::Type type, MemberOffset off, uint32_t dex_pc = kNoDexPc) { HInstanceFieldGet* ifield_get = new (GetAllocator()) HInstanceFieldGet( - inst, + object, /* field= */ nullptr, /* field_type= */ type, /* field_offset= */ off, -- cgit v1.2.3-59-g8ed1b